Skip to content

Commit ef6f923

Browse files
simplereader: Fix warning about use of pointer variable after free()
We weren't dereferencing the variable, so this should have been safe. However, it isn't clear in the C and C++ standards whether it legitimately was safe. So let's just fix it. ``` simplereader.c:180:9: warning: pointer ‘buf’ may be used after ‘free’ [-Wuse-after-free] simplereader.c:177:5: note: call to ‘free’ here ``` Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
1 parent 9487c1b commit ef6f923

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

examples/simplereader.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,13 @@ int main(int argc, char **argv)
174174
CborError err = cbor_parser_init(buf, length, 0, &parser, &it);
175175
if (!err)
176176
err = dumprecursive(&it, 0);
177-
free(buf);
178177

179178
if (err) {
180179
fprintf(stderr, "CBOR parsing failure at offset %ld: %s\n",
181180
cbor_value_get_next_byte(&it) - buf, cbor_error_string(err));
181+
free(buf);
182182
return 1;
183183
}
184+
free(buf);
184185
return 0;
185186
}

0 commit comments

Comments
 (0)