Skip to content

Commit fbad57e

Browse files
Add tests for not tested functions.
Change-Id: I02f14d8176fc53eb12b90d5b6145672ef01ccdb0
1 parent acf9799 commit fbad57e

File tree

4 files changed

+36
-6
lines changed

4 files changed

+36
-6
lines changed

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!groovy
22
neoDependenciesRev='753855-910'
33
strategy='EQUAL'
4-
allowedF=8
4+
allowedF=3
55
allowedCD=309

unit_tests/command_stream/tbx_command_stream_tests.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,3 +277,8 @@ HWTEST_F(TbxCommandStreamTests, givenTbxCommandStreamReceiverWhenFlushIsCalledTh
277277
memoryManager->freeGraphicsMemory(commandBuffer);
278278
memoryManager->freeGraphicsMemory(graphicsAllocation);
279279
}
280+
281+
TEST(TbxMemoryManagerTest, givenTbxMemoryManagerWhenItIsQueriedForSystemSharedMemoryThen1GBIsReturned) {
282+
TbxMemoryManager memoryManager;
283+
EXPECT_EQ(1 * GB, memoryManager.getSystemSharedMemory());
284+
}

unit_tests/mem_obj/image_tests.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,6 +1011,16 @@ TEST(ImageTest, givenImageWhenAskedForPtrOffsetForGpuMappingThenReturnCorrectVal
10111011
EXPECT_EQ(expectedOffset, retOffset);
10121012
}
10131013

1014+
TEST(ImageTest, givenImageWhenAskedForMcsInfoThenDefaultValuesAreReturned) {
1015+
MockContext ctx;
1016+
std::unique_ptr<Image> image(ImageHelper<Image3dDefaults>::create(&ctx));
1017+
1018+
auto mcsInfo = image->getMcsSurfaceInfo();
1019+
EXPECT_EQ(0u, mcsInfo.multisampleCount);
1020+
EXPECT_EQ(0u, mcsInfo.qPitch);
1021+
EXPECT_EQ(0u, mcsInfo.pitch);
1022+
}
1023+
10141024
TEST(ImageTest, givenImageWhenAskedForPtrOffsetForCpuMappingThenReturnCorrectValue) {
10151025
DebugManagerStateRestore restore;
10161026
DebugManager.flags.ForceLinearImages.set(true);

unit_tests/os_interface/linux/drm_tests.cpp

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ TEST(DrmTest, GetRevisionID) {
131131
delete pDrm;
132132
}
133133

134-
TEST(DrmTest, GivenMockDrmWhenAskedFor48BitAddressCorrectValueReturned) {
134+
TEST(DrmTest, GivenDrmWhenAskedFor48BitAddressCorrectValueReturned) {
135135
DrmMock *pDrm = new DrmMock;
136136
pDrm->StoredPPGTT = 3;
137137
EXPECT_TRUE(pDrm->is48BitAddressRangeSupported());
@@ -141,7 +141,7 @@ TEST(DrmTest, GivenMockDrmWhenAskedFor48BitAddressCorrectValueReturned) {
141141
}
142142

143143
#if defined(I915_PARAM_HAS_PREEMPTION)
144-
TEST(DrmTest, GivenMockDrmWhenAskedForPreemptionCorrectValueReturned) {
144+
TEST(DrmTest, GivenDrmWhenAskedForPreemptionCorrectValueReturned) {
145145
DrmMock *pDrm = new DrmMock;
146146
pDrm->StoredPreemptionSupport = 1;
147147
EXPECT_TRUE(pDrm->hasPreemption());
@@ -150,7 +150,7 @@ TEST(DrmTest, GivenMockDrmWhenAskedForPreemptionCorrectValueReturned) {
150150
delete pDrm;
151151
}
152152

153-
TEST(DrmTest, GivenMockDrmWhenAskedForContextThatPassedThenValidContextIdsReturned) {
153+
TEST(DrmTest, GivenDrmWhenAskedForContextThatPassedThenValidContextIdsReturned) {
154154
DrmMock *pDrm = new DrmMock;
155155
EXPECT_EQ(0u, pDrm->lowPriorityContextId);
156156
pDrm->StoredRetVal = 0;
@@ -162,22 +162,37 @@ TEST(DrmTest, GivenMockDrmWhenAskedForContextThatPassedThenValidContextIdsReturn
162162
delete pDrm;
163163
}
164164

165-
TEST(DrmTest, GivenMockDrmWhenAskedForContextThatFailsThenFalseIsReturned) {
165+
TEST(DrmTest, GivenDrmWhenAskedForContextThatFailsThenFalseIsReturned) {
166166
DrmMock *pDrm = new DrmMock;
167167
pDrm->StoredRetVal = -1;
168168
EXPECT_FALSE(pDrm->contextCreate());
169169
pDrm->StoredRetVal = 0;
170170
delete pDrm;
171171
}
172172

173-
TEST(DrmTest, GivenMockDrmWhenAskedForContextWithLowPriorityThatFailsThenFalseIsReturned) {
173+
TEST(DrmTest, GivenDrmWhenAskedForContextWithLowPriorityThatFailsThenFalseIsReturned) {
174174
DrmMock *pDrm = new DrmMock;
175175
EXPECT_TRUE(pDrm->contextCreate());
176176
pDrm->StoredRetVal = -1;
177177
EXPECT_FALSE(pDrm->setLowPriority());
178178
pDrm->StoredRetVal = 0;
179179
delete pDrm;
180180
}
181+
#else
182+
TEST(DrmTest, GivenDrmWhenAskedForContextWithLowPriorityThenFalseIsReturned) {
183+
DrmMock drmMock;
184+
EXPECT_FALSE(drmMock.contextCreate());
185+
}
186+
187+
TEST(DrmTest, GivenDrmWhenContextDestroyIsCalledThenThereAreNoLeaksOrCrashes) {
188+
DrmMock drmMock;
189+
drmMock.contextDestroy();
190+
}
191+
192+
TEST(DrmTest, GivenDrmWhenSetContextPriorityIsCalledThenFalseIsReturned) {
193+
DrmMock drmMock;
194+
EXPECT_FALSE(drmMock.setLowPriority());
195+
}
181196
#endif
182197

183198
TEST(DrmTest, getExecSoftPin) {

0 commit comments

Comments
 (0)