Revert "Check indirect access from igc"

This reverts commit e14c91f.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>

Author: Compute-Runtime-Validation

level_zero/core/source/kernel/kernel_imp.cpp

@@ -238,7 +238,7 @@ KernelImp::~KernelImp() {
         alignedFree(perThreadDataForWholeThreadGroup);
     }
     if (printfBuffer != nullptr) {
-        // not allowed to call virtual function on destructor, so calling printOutput directly
+        //not allowed to call virtual function on destructor, so calling printOutput directly
         PrintfHandler::printOutput(kernelImmData, this->printfBuffer, module->getDevice());
         module->getDevice()->getNEODevice()->getMemoryManager()->freeGraphicsMemory(printfBuffer);
     }
@@ -901,8 +901,7 @@ ze_result_t KernelImp::initialize(const ze_kernel_desc_t *desc) {
 
     kernelHasIndirectAccess = kernelDescriptor.kernelAttributes.hasNonKernelArgLoad ||
                               kernelDescriptor.kernelAttributes.hasNonKernelArgStore ||
-                              kernelDescriptor.kernelAttributes.hasNonKernelArgAtomic ||
-                              getImmutableData()->getKernelInfo()->hasIndirectStatelessAccess;
+                              kernelDescriptor.kernelAttributes.hasNonKernelArgAtomic;
 
     if (this->usesRayTracing()) {
         if (this->getImmutableData()->getDescriptor().payloadMappings.implicitArgs.rtDispatchGlobals.pointerSize > 0) {
@@ -1029,9 +1028,9 @@ Kernel *Kernel::create(uint32_t productFamily, Module *module,
 }
 
 bool KernelImp::hasIndirectAllocationsAllowed() const {
-    return this->kernelHasIndirectAccess && (unifiedMemoryControls.indirectDeviceAllocationsAllowed ||
-                                             unifiedMemoryControls.indirectHostAllocationsAllowed ||
-                                             unifiedMemoryControls.indirectSharedAllocationsAllowed);
+    return (unifiedMemoryControls.indirectDeviceAllocationsAllowed ||
+            unifiedMemoryControls.indirectHostAllocationsAllowed ||
+            unifiedMemoryControls.indirectSharedAllocationsAllowed);
 }
 
 uint32_t KernelImp::getSlmTotalSize() const {

level_zero/core/source/kernel/kernel_imp.h

@@ -148,7 +148,7 @@ struct KernelImp : Kernel {
 
     ze_result_t getProfileInfo(zet_profile_properties_t *pProfileProperties) override;
 
-    bool hasIndirectAccess() const {
+    bool hasIndirectAccess() {
         return kernelHasIndirectAccess;
     }
 

level_zero/core/test/unit_tests/mocks/mock_kernel.h

@@ -46,7 +46,6 @@ struct WhiteBox<::L0::Kernel> : public ::L0::KernelImp {
     using ::L0::KernelImp::crossThreadData;
     using ::L0::KernelImp::crossThreadDataSize;
     using ::L0::KernelImp::groupSize;
-    using ::L0::KernelImp::kernelHasIndirectAccess;
     using ::L0::KernelImp::kernelImmData;
     using ::L0::KernelImp::kernelRequiresGenerationOfLocalIdsByRuntime;
     using ::L0::KernelImp::module;

level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_1.cpp

@@ -29,7 +29,6 @@ using CommandListAppendLaunchKernel = Test<ModuleFixture>;
 
 HWTEST_F(CommandListAppendLaunchKernel, givenKernelWithIndirectAllocationsAllowedThenCommandListReturnsExpectedIndirectAllocationsAllowed) {
     createKernel();
-    kernel->kernelHasIndirectAccess = true;
     kernel->unifiedMemoryControls.indirectDeviceAllocationsAllowed = true;
     kernel->unifiedMemoryControls.indirectSharedAllocationsAllowed = true;
     kernel->unifiedMemoryControls.indirectHostAllocationsAllowed = true;

level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_3.cpp

@@ -378,7 +378,6 @@ HWTEST_F(CommandQueueIndirectAllocations, givenCommandQueueWhenExecutingCommandL
     ASSERT_NE(nullptr, gpuAlloc);
 
     createKernel();
-    kernel->kernelHasIndirectAccess = true;
     kernel->unifiedMemoryControls.indirectDeviceAllocationsAllowed = true;
     EXPECT_TRUE(kernel->getUnifiedMemoryControls().indirectDeviceAllocationsAllowed);
 
@@ -443,7 +442,6 @@ HWTEST_F(CommandQueueIndirectAllocations, givenDebugModeToTreatIndirectAllocatio
     ASSERT_NE(nullptr, gpuAlloc);
 
     createKernel();
-    kernel->kernelHasIndirectAccess = true;
     kernel->unifiedMemoryControls.indirectDeviceAllocationsAllowed = true;
     EXPECT_TRUE(kernel->getUnifiedMemoryControls().indirectDeviceAllocationsAllowed);
 
@@ -507,7 +505,6 @@ HWTEST_F(CommandQueueIndirectAllocations, givenDeviceThatSupportsSubmittingIndir
     ASSERT_NE(nullptr, gpuAlloc);
 
     createKernel();
-    kernel->kernelHasIndirectAccess = true;
     kernel->unifiedMemoryControls.indirectDeviceAllocationsAllowed = true;
     EXPECT_TRUE(kernel->getUnifiedMemoryControls().indirectDeviceAllocationsAllowed);
 
@@ -572,7 +569,6 @@ HWTEST_F(CommandQueueIndirectAllocations, givenDeviceThatSupportsSubmittingIndir
     ASSERT_NE(nullptr, gpuAlloc);
 
     createKernel();
-    kernel->kernelHasIndirectAccess = true;
     kernel->unifiedMemoryControls.indirectDeviceAllocationsAllowed = true;
     EXPECT_TRUE(kernel->getUnifiedMemoryControls().indirectDeviceAllocationsAllowed);
 

opencl/source/kernel/kernel.cpp

@@ -258,8 +258,7 @@ cl_int Kernel::initialize() {
 
     this->kernelHasIndirectAccess |= kernelInfo.kernelDescriptor.kernelAttributes.hasNonKernelArgLoad ||
                                      kernelInfo.kernelDescriptor.kernelAttributes.hasNonKernelArgStore ||
-                                     kernelInfo.kernelDescriptor.kernelAttributes.hasNonKernelArgAtomic ||
-                                     kernelInfo.hasIndirectStatelessAccess;
+                                     kernelInfo.kernelDescriptor.kernelAttributes.hasNonKernelArgAtomic;
 
     provideInitializationHints();
     // resolve the new kernel info to account for kernel handlers
@@ -1252,9 +1251,9 @@ void Kernel::makeResident(CommandStreamReceiver &commandStreamReceiver) {
 
     gtpinNotifyMakeResident(this, &commandStreamReceiver);
 
-    if (this->kernelHasIndirectAccess && (unifiedMemoryControls.indirectDeviceAllocationsAllowed ||
-                                          unifiedMemoryControls.indirectHostAllocationsAllowed ||
-                                          unifiedMemoryControls.indirectSharedAllocationsAllowed)) {
+    if (unifiedMemoryControls.indirectDeviceAllocationsAllowed ||
+        unifiedMemoryControls.indirectHostAllocationsAllowed ||
+        unifiedMemoryControls.indirectSharedAllocationsAllowed) {
         this->getContext().getSVMAllocsManager()->makeInternalAllocationsResident(commandStreamReceiver, unifiedMemoryControls.generateMask());
     }
 }

shared/source/device_binary_format/zebin_decoder.cpp

@@ -326,9 +326,6 @@ DecodeError readZeInfoExperimentalProperties(const NEO::Yaml::YamlParser &parser
                                              ConstStringRef context,
                                              std::string &outErrReason, std::string &outWarning) {
     bool validExperimentalProperty = true;
-    outExperimentalProperties.hasNonKernelArgLoad = true;
-    outExperimentalProperties.hasNonKernelArgStore = true;
-    outExperimentalProperties.hasNonKernelArgAtomic = true;
     for (const auto &experimentalPropertyNd : parser.createChildrenRange(node)) {
         for (const auto &experimentalPropertyMemberNd : parser.createChildrenRange(experimentalPropertyNd)) {
             auto key = parser.readKey(experimentalPropertyMemberNd);

shared/source/kernel/kernel_descriptor.h

@@ -151,9 +151,9 @@ struct KernelDescriptor {
         uint16_t numArgsToPatch = 0U;
         uint16_t numGrfRequired = 0U;
         uint8_t barrierCount = 0u;
-        bool hasNonKernelArgLoad = false;
-        bool hasNonKernelArgStore = false;
-        bool hasNonKernelArgAtomic = false;
+        bool hasNonKernelArgLoad = true;
+        bool hasNonKernelArgStore = true;
+        bool hasNonKernelArgAtomic = true;
 
         AddressingMode bufferAddressingMode = BindfulAndStateless;
         AddressingMode imageAddressingMode = Bindful;