clang-tidy configuration cleanup

Define single .clang-tidy configuration with all used checks and use
NOLINT to selectively silence tool. That way cleanup should be easier.
third_part/ has its own configuration that disables clang-tidy for this
folder.

Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>

Author: ArturHarasimiuk

.clang-tidy

@@ -1,7 +1,7 @@
 ---
 Checks:          'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,readability-identifier-naming,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*'
-# WarningsAsErrors: '.*'
-HeaderFilterRegex: '^((?!^third_party\/).+)\.(h|hpp|inl)$'
+WarningsAsErrors: '.*'
+HeaderFilterRegex: '(shared|opencl|level_zero).+\.(h|hpp|inl)$'
 AnalyzeTemporaryDtors: false
 CheckOptions:
   - key:             google-readability-braces-around-statements.ShortStatementLines
@@ -16,8 +16,6 @@ CheckOptions:
     value:           camelBack
   - key:             readability-identifier-naming.ParameterCase
     value:           camelBack
-  - key:             readability-identifier-naming.StructMemberCase
-    value:           camelBack
   - key:             readability-identifier-naming.ClassMemberCase
     value:           camelBack
   - key:             readability-identifier-naming.ClassMethodCase

level_zero/core/source/context/context.h

@@ -35,7 +35,7 @@ struct Context : _ze_context_handle_t {
         return ZE_MEMORY_TYPE_UNKNOWN;
     }
 
-    virtual ~Context() = default;
+    ~Context() override = default;
     virtual ze_result_t destroy() = 0;
     virtual ze_result_t getStatus() = 0;
     virtual DriverHandle *getDriverHandle() = 0;

level_zero/core/source/device/device_imp.cpp

@@ -414,10 +414,10 @@ ze_result_t DeviceImp::getPciProperties(ze_pci_ext_properties_t *pPciProperties)
     }
     auto pciBusInfo = driverInfo->getPciBusInfo();
     auto isPciValid = [&](auto pci) -> bool {
-        return (pci.pciDomain != NEO::PhysicalDevicePciBusInfo::InvalidValue &&
-                pci.pciBus != NEO::PhysicalDevicePciBusInfo::InvalidValue &&
-                pci.pciDevice != NEO::PhysicalDevicePciBusInfo::InvalidValue &&
-                pci.pciFunction != NEO::PhysicalDevicePciBusInfo::InvalidValue);
+        return (pci.pciDomain != NEO::PhysicalDevicePciBusInfo::invalidValue &&
+                pci.pciBus != NEO::PhysicalDevicePciBusInfo::invalidValue &&
+                pci.pciDevice != NEO::PhysicalDevicePciBusInfo::invalidValue &&
+                pci.pciFunction != NEO::PhysicalDevicePciBusInfo::invalidValue);
     };
     if (!isPciValid(pciBusInfo)) {
         return ZE_RESULT_ERROR_UNINITIALIZED;

level_zero/core/source/driver/driver_handle_imp.h

@@ -57,11 +57,11 @@ struct DriverHandleImp : public DriverHandle {
     ze_result_t releaseImportedPointer(void *ptr) override;
     ze_result_t getHostPointerBaseAddress(void *ptr, void **baseAddress) override;
 
-    virtual NEO::GraphicsAllocation *findHostPointerAllocation(void *ptr, size_t size, uint32_t rootDeviceIndex) override;
-    virtual NEO::GraphicsAllocation *getDriverSystemMemoryAllocation(void *ptr,
-                                                                     size_t size,
-                                                                     uint32_t rootDeviceIndex,
-                                                                     uintptr_t *gpuAddress) override;
+    NEO::GraphicsAllocation *findHostPointerAllocation(void *ptr, size_t size, uint32_t rootDeviceIndex) override;
+    NEO::GraphicsAllocation *getDriverSystemMemoryAllocation(void *ptr,
+                                                             size_t size,
+                                                             uint32_t rootDeviceIndex,
+                                                             uintptr_t *gpuAddress) override;
     NEO::GraphicsAllocation *getPeerAllocation(Device *device,
                                                NEO::SvmAllocationData *allocData,
                                                void *basePtr,

level_zero/core/source/event/event.h

@@ -248,7 +248,7 @@ struct EventPoolImp : public EventPool {
 
     ze_result_t initialize(DriverHandle *driver, Context *context, uint32_t numDevices, ze_device_handle_t *phDevices);
 
-    ~EventPoolImp();
+    ~EventPoolImp() override;
 
     ze_result_t destroy() override;
 

level_zero/core/test/.clang-tidy

@@ -41,9 +41,9 @@ class AUBFixtureL0 {
   public:
     AUBFixtureL0();
     virtual ~AUBFixtureL0();
-    void SetUp();
-    void SetUp(const NEO::HardwareInfo *hardwareInfo, bool debuggingEnabled);
-    void TearDown();
+    void SetUp();                                                             // NOLINT(readability-identifier-naming)
+    void SetUp(const NEO::HardwareInfo *hardwareInfo, bool debuggingEnabled); // NOLINT(readability-identifier-naming)
+    void TearDown();                                                          // NOLINT(readability-identifier-naming)
     static void prepareCopyEngines(NEO::MockDevice &device, const std::string &filename);
 
     template <typename FamilyType>
@@ -110,4 +110,4 @@ class AUBFixtureL0 {
     NEO::CommandStreamReceiver *csr = nullptr;
 };
 
-} // namespace L0
+} // namespace L0

level_zero/core/test/aub_tests/fixtures/aub_fixture.h

@@ -30,7 +30,7 @@ void testCopyBetweenHeapDeviceAndStack(ze_context_handle_t &context, ze_device_h
     ze_command_queue_desc_t cmdQueueDesc = {ZE_STRUCTURE_TYPE_COMMAND_QUEUE_DESC};
     int32_t copyQueueGroup = getCopyOnlyCommandQueueOrdinal(device);
     if (copyQueueGroup < 0) {
-        std::cout << "No Copy queue group found. Skipping test run\n";
+        std::cout << "No Copy queue group found. Skipping test run\n"; // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
         validRet = true;
         return;
     }
@@ -105,7 +105,7 @@ void testCopyBetweenHostMemAndDeviceMem(ze_context_handle_t &context, ze_device_
     ze_command_queue_desc_t cmdQueueDesc = {ZE_STRUCTURE_TYPE_COMMAND_QUEUE_DESC};
     int32_t copyQueueGroup = getCopyOnlyCommandQueueOrdinal(device);
     if (copyQueueGroup < 0) {
-        std::cout << "No Copy queue group found. Skipping test run\n";
+        std::cout << "No Copy queue group found. Skipping test run\n"; // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
         validRet = true;
         return;
     }
@@ -310,7 +310,7 @@ void testSharedMemDataAccessWithoutCopy(ze_context_handle_t &context, ze_device_
     ze_command_queue_desc_t cmdQueueDesc = {ZE_STRUCTURE_TYPE_COMMAND_QUEUE_DESC};
     int32_t copyQueueGroup = getCopyOnlyCommandQueueOrdinal(device);
     if (copyQueueGroup < 0) {
-        std::cout << "No Copy queue group found. Skipping test run\n";
+        std::cout << "No Copy queue group found. Skipping test run\n"; // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
         validRet = true;
         return;
     }

level_zero/core/test/black_box_tests/zello_copy_only.cpp

@@ -64,7 +64,7 @@ static int recvmsgForIpcHandle(int socket, char *payload) {
         return -1;
     }
     struct cmsghdr *controlHeader = CMSG_FIRSTHDR(&msgHeader);
-    memmove(&fd, CMSG_DATA(controlHeader), sizeof(int));
+    memmove(&fd, CMSG_DATA(controlHeader), sizeof(int)); // NOLINT(clang-analyzer-core.NonNullParamChecker)
     memmove(payload, recvBuf, sizeof(recvBuf));
     return fd;
 }

level_zero/core/test/black_box_tests/zello_ipc_copy_dma_buf.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021 Intel Corporation
+ * Copyright (C) 2021-2022 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -20,14 +20,14 @@ namespace L0 {
 namespace ult {
 struct AubCsrFixture : public ContextFixture {
     template <typename T>
-    void SetUpT() {
+    void setUpT() {
         auto csrCreateFcn = &commandStreamReceiverFactory[IGFX_MAX_CORE + NEO::defaultHwInfo->platform.eRenderCoreFamily];
         variableBackup = std::make_unique<VariableBackup<CommandStreamReceiverCreateFunc>>(csrCreateFcn);
         *csrCreateFcn = UltAubCommandStreamReceiver<T>::create;
         ContextFixture::SetUp();
     }
     template <typename T>
-    void TearDownT() {
+    void tearDownT() {
         ContextFixture::TearDown();
     }