sharing: add context tests

Change-Id: I1dc504f6931ab0ae5645e9460ae0c0284704404c

Author: JacekDanecki

runtime/context/context.inl

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Intel Corporation
+ * Copyright (c) 2017 - 2018, Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -31,7 +31,9 @@ void Context::registerSharing(Sharing *sharing) {
 
 template <typename Sharing>
 Sharing *Context::getSharing() {
-    UNRECOVERABLE_IF(Sharing::sharingId >= sharingFunctions.size());
+    if (Sharing::sharingId >= sharingFunctions.size()) {
+        return nullptr;
+    }
 
     return reinterpret_cast<Sharing *>(sharingFunctions[Sharing::sharingId].get());
 }

runtime/os_interface/windows/d3d10_11_sharing_functions.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Intel Corporation
+ * Copyright (c) 2017 - 2018, Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -20,7 +20,6 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "runtime/context/context.h"
 #include "runtime/context/context.inl"
 #include "runtime/os_interface/windows/d3d_sharing_functions.h"
 #include "runtime/sharings/sharing_factory.h"
@@ -224,4 +223,4 @@ void D3DSharingFunctions<D3D>::getDxgiDesc(DXGI_ADAPTER_DESC *dxgiDesc, IDXGIAda
 }
 
 template D3DSharingFunctions<D3DTypesHelper::D3D10> *Context::getSharing<D3DSharingFunctions<D3DTypesHelper::D3D10>>();
-template D3DSharingFunctions<D3DTypesHelper::D3D11> *Context::getSharing<D3DSharingFunctions<D3DTypesHelper::D3D11>>();
+template D3DSharingFunctions<D3DTypesHelper::D3D11> *Context::getSharing<D3DSharingFunctions<D3DTypesHelper::D3D11>>();

runtime/os_interface/windows/d3d9_sharing_functions.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Intel Corporation
+ * Copyright (c) 2017 - 2018, Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -20,7 +20,6 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "runtime/context/context.h"
 #include "runtime/context/context.inl"
 #include "runtime/os_interface/windows/d3d_sharing_functions.h"
 #include "runtime/sharings/sharing_factory.h"
@@ -153,4 +152,4 @@ void D3DSharingFunctions<D3DTypesHelper::D3D9>::getDxgiDesc(DXGI_ADAPTER_DESC *d
     adapter->Release();
 }
 
-template D3DSharingFunctions<D3DTypesHelper::D3D9> *Context::getSharing<D3DSharingFunctions<D3DTypesHelper::D3D9>>();
+template D3DSharingFunctions<D3DTypesHelper::D3D9> *Context::getSharing<D3DSharingFunctions<D3DTypesHelper::D3D9>>();

runtime/sharings/va/va_sharing.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Intel Corporation
+ * Copyright (c) 2017 - 2018, Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -20,21 +20,13 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "runtime/context/context.h"
+#include "runtime/context/context.inl"
 #include "runtime/sharings/sharing_factory.h"
 #include "runtime/sharings/va/va_sharing_defines.h"
 #include "runtime/sharings/va/va_sharing_functions.h"
 
 namespace OCLRT {
 const uint32_t VASharingFunctions::sharingId = SharingType::VA_SHARING;
 
-template <>
-VASharingFunctions *Context::getSharing() {
-    if (VASharingFunctions::sharingId >= sharingFunctions.size()) {
-        DEBUG_BREAK_IF(VASharingFunctions::sharingId >= sharingFunctions.size());
-        return nullptr;
-    }
-
-    return reinterpret_cast<VASharingFunctions *>(sharingFunctions[VASharingFunctions::sharingId].get());
-}
+template VASharingFunctions *Context::getSharing<VASharingFunctions>();
 }

unit_tests/context/context_tests.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Intel Corporation
+ * Copyright (c) 2017 - 2018, Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -20,13 +20,14 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "runtime/context/context.h"
-#include "runtime/device/device.h"
-#include "runtime/helpers/options.h"
+#include "gtest/gtest.h"
+#include "runtime/context/context.inl"
 #include "runtime/command_queue/command_queue.h"
+#include "runtime/device/device.h"
 #include "runtime/device_queue/device_queue.h"
+#include "runtime/helpers/options.h"
+#include "runtime/sharings/sharing.h"
 #include "unit_tests/fixtures/platform_fixture.h"
-#include "gtest/gtest.h"
 #include "unit_tests/helpers/debug_manager_state_restore.h"
 #include "unit_tests/mocks/mock_context.h"
 #include "unit_tests/mocks/mock_deferred_deleter.h"
@@ -262,6 +263,29 @@ TEST_F(ContextTest, GivenInteropSyncParamWhenCreateContextThenSetContextParam) {
     delete context;
 }
 
+class MockSharingFunctions : public SharingFunctions {
+  public:
+    uint32_t getId() const override {
+        return sharingId;
+    }
+    static const uint32_t sharingId = 0;
+};
+
+TEST_F(ContextTest, givenContextWhenSharingTableEmptyThenReturnsNullptr) {
+    MockContext context;
+    context.clearSharingFunctions();
+    auto *sharingF = context.getSharing<MockSharingFunctions>();
+    EXPECT_EQ(sharingF, nullptr);
+}
+
+TEST_F(ContextTest, givenContextWhenSharingTableIsNotEmptyThenReturnsSharingFunctionPointer) {
+    MockContext context;
+    MockSharingFunctions *sharingFunctions = new MockSharingFunctions;
+    context.registerSharing<MockSharingFunctions>(sharingFunctions);
+    auto *sharingF = context.getSharing<MockSharingFunctions>();
+    EXPECT_EQ(sharingF, sharingFunctions);
+}
+
 class ContextWithAsyncDeleterTest : public ::testing::WithParamInterface<bool>,
                                     public ::testing::Test {
   public:

unit_tests/sharings/va/va_sharing_tests.cpp

@@ -397,7 +397,7 @@ TEST_F(VaSharingTests, givenVaSurfaceWhenCreateImageFromParentThenSetMediaPlaneT
     EXPECT_EQ(CL_SUCCESS, errCode);
 }
 
-TEST_F(VaSharingTests, givenContextWhenEmptySharingTableEmptyThenReturnsNullptr) {
+TEST_F(VaSharingTests, givenContextWhenSharingTableEmptyThenReturnsNullptr) {
     MockContext context;
     context.clearSharingFunctions();
     VASharingFunctions *sharingF = context.getSharing<VASharingFunctions>();