From 4a88ad14499d7e88d1bce4056411d6cf0cc09810 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Raynaud Date: Wed, 26 Jun 2024 18:01:19 +0200 Subject: [PATCH 1/4] DO NOT MERGE --- mithril-common/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mithril-common/Cargo.toml b/mithril-common/Cargo.toml index a804954dc5e..04b63d448c2 100644 --- a/mithril-common/Cargo.toml +++ b/mithril-common/Cargo.toml @@ -19,7 +19,7 @@ rustdoc-args = ["--cfg", "docsrs"] ignored = ["serde_bytes"] [features] -default = ["rug-backend"] +default = ["rug-backend", "allow_skip_signer_certification"] # Enables `rug-backend` features for `mithril-stm` dependency rug-backend = ["mithril-stm/rug-backend"] From c2b503a8e99f58892c375ec40570ab905ba6144b Mon Sep 17 00:00:00 2001 From: Jean-Philippe Raynaud Date: Thu, 11 Dec 2025 12:02:09 +0100 Subject: [PATCH 2/4] fix(ci): test pool id for 'dev-follower-preview' network --- .github/workflows/test-deploy-network.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-deploy-network.yml b/.github/workflows/test-deploy-network.yml index 04996133bb9..819da5744f9 100644 --- a/.github/workflows/test-deploy-network.yml +++ b/.github/workflows/test-deploy-network.yml @@ -89,7 +89,7 @@ jobs: { "1" = { type = "unverified-cardano-passive-norelay", - pool_id = "pool1y0uxkqyplyx6ld25e976t0s35va3ysqcscatwvy2sd2cwcareq7", + pool_id = "pool13zafxlpfgymf474uv52qt557z5k5frn9p83yr55zp267wj5mpu4", }, } mithril_leader_aggregator_endpoint: https://aggregator.dev-preview.api.mithril.network/aggregator From dc195dca390fcaa9779acc6af331e5c02a3488fd Mon Sep 17 00:00:00 2001 From: Jean-Philippe Raynaud Date: Wed, 17 Dec 2025 13:35:35 +0100 Subject: [PATCH 3/4] wip(dmq): update DMQ magic id for preview - DO NOT MERGE --- internal/mithril-dmq/src/model/network.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/mithril-dmq/src/model/network.rs b/internal/mithril-dmq/src/model/network.rs index 5924037a1cc..d72ab2b55dd 100644 --- a/internal/mithril-dmq/src/model/network.rs +++ b/internal/mithril-dmq/src/model/network.rs @@ -27,9 +27,9 @@ impl DmqNetwork { /// Preprod magic ID pub const PREPROD_MAGIC_ID: MagicId = 1; // TODO: Update magic ids for networks /// Preview magic ID - pub const PREVIEW_MAGIC_ID: MagicId = 2; // TODO: Update magic ids for networks + pub const PREVIEW_MAGIC_ID: MagicId = 3141592; // TODO: Update magic ids for networks /// Devnet magic ID - pub(crate) const DEVNET_MAGIC_ID: MagicId = 3141592; // TODO: Update magic ids for networks + pub(crate) const DEVNET_MAGIC_ID: MagicId = 0; // TODO: Update magic ids for networks /// Instantiates a DmqNetwork from its code and magic id pub fn from_code( From ee79bc13a7fec38b2df6ee1056d8f6f8d8f46310 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Raynaud Date: Mon, 22 Dec 2025 19:26:29 +0100 Subject: [PATCH 4/4] wip(aggregator): better support of some errors in signature processor --- .../src/services/signature_processor.rs | 29 +++++++++++++------ 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/mithril-aggregator/src/services/signature_processor.rs b/mithril-aggregator/src/services/signature_processor.rs index 5f3c63a2b65..5530b96f63b 100644 --- a/mithril-aggregator/src/services/signature_processor.rs +++ b/mithril-aggregator/src/services/signature_processor.rs @@ -1,7 +1,7 @@ use std::{sync::Arc, time::Duration}; use anyhow::anyhow; -use slog::{Logger, error, trace, warn}; +use slog::{Logger, debug, error, trace, warn}; use mithril_common::{ StdResult, @@ -10,7 +10,7 @@ use mithril_common::{ }; use tokio::{select, sync::watch::Receiver}; -use crate::MetricsService; +use crate::{MetricsService, services::CertifierServiceError}; use super::{CertifierService, SignatureConsumer}; @@ -90,13 +90,24 @@ impl SignatureProcessor for SequentialSignatureProcessor { .get_signature_registration_total_successful_since_startup() .increment(&[&origin_network]); } - Err(e) => { - total_import_errors += 1; - error!( - self.logger, "Error dispatching single signature"; - "full_payload" => #?signature, "error" => ?e - ); - } + Err(err) => match err.downcast_ref::() { + Some(CertifierServiceError::AlreadyCertified(signed_entity_type)) => { + debug!(self.logger, "process_signatures::open_message_already_certified"; "signed_entity_type" => ?signed_entity_type, "party_id" => &signature.party_id); + } + Some(CertifierServiceError::Expired(signed_entity_type)) => { + debug!(self.logger, "process_signatures::open_message_expired"; "signed_entity_type" => ?signed_entity_type, "party_id" => &signature.party_id); + } + Some(CertifierServiceError::NotFound(signed_entity_type)) => { + debug!(self.logger, "process_signatures::not_found"; "signed_entity_type" => ?signed_entity_type, "party_id" => &signature.party_id); + } + Some(_) | None => { + total_import_errors += 1; + error!( + self.logger, "Error dispatching single signature"; + "full_payload" => #?signature, "error" => ?err + ); + } + }, } } }