refactor(aggregator): use number of KES evolutions to verify key registration

Author: jpraynaud

mithril-aggregator/src/services/signer_registration/verifier.rs

@@ -42,7 +42,7 @@ impl SignerRegistrationVerifier for MithrilSignerRegistrationVerifier {
             "" => None,
             party_id => Some(party_id.to_string()),
         };
-        let kes_period = match &signer.operational_certificate {
+        let kes_evolutions = match &signer.operational_certificate {
             Some(operational_certificate) => Some(
                 self.chain_observer
                     .get_current_kes_period()
@@ -57,12 +57,12 @@ impl SignerRegistrationVerifier for MithrilSignerRegistrationVerifier {
                 party_id_register.clone(),
                 signer.operational_certificate.clone(),
                 signer.verification_key_signature,
-                kes_period,
+                kes_evolutions,
                 signer.verification_key,
             )
             .with_context(|| {
                 format!(
-                    "KeyRegwrapper can not register signer with party_id: '{party_id_register:?}', kes_period: '{kes_period:?}'"
+                    "KeyRegwrapper can not register signer with party_id: '{party_id_register:?}', kes_evolutions: '{kes_evolutions:?}'"
                 )
             })?;
         let party_id_registered_stake = *stake_distribution

mithril-common/src/crypto_helper/cardano/key_certification.rs

@@ -117,15 +117,15 @@ impl StmInitializerWrapper {
     pub fn setup<R: RngCore + CryptoRng>(
         params: Parameters,
         kes_signer: Option<Arc<dyn KesSigner>>,
-        kes_period: Option<KesPeriod>,
+        current_kes_period: Option<KesPeriod>,
         stake: Stake,
         rng: &mut R,
     ) -> StdResult<Self> {
         let stm_initializer = Initializer::new(params, stake, rng);
         let kes_signature = if let Some(kes_signer) = kes_signer {
             let (signature, _op_cert) = kes_signer.sign(
                 &stm_initializer.get_verification_key_proof_of_possession().to_bytes(),
-                kes_period.unwrap_or_default(),
+                current_kes_period.unwrap_or_default(),
             )?;
 
             Some(signature)