-
Notifications
You must be signed in to change notification settings - Fork 259
Patches for 9.12 for reinstallable libraries to build #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dten
wants to merge
11
commits into
input-output-hk:master
Choose a base branch
from
dten:fix-9.12-redistributable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hmm whilst this fixes the linked issue's repro my own project progresses but stops at the below when targetting nightly-2025-10-01. i'll dig some more |
the alex patch comes from a ghc MR so should not be needed in future https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13782 the Cabal one is inspired by the patch already applied for 9.10 to build with Cabal-3.11
0ed7f69 to
26389be
Compare
Contributor
Author
|
ah it was a local issue this patch should be all good 🤞 (I had half of another attempted fix still in confusing it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2432
not sure if this is how you'd like to do but since there was already a patch for Cabal-3.11 and ghc-9.10 I took this as reasonable method
the alex patch comes from a ghc MR so should not be needed in future https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13782
the Cabal one is inspired by the patch already applied for 9.10 to build with Cabal-3.11
the Setup files in ghc master still don't support 3.14 so i guess 9.14 will need to apply the patch too when supported