feat: SignetL1 #4
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
81ecee3 to
319d8a7
Compare
prestwich
force-pushed
the
prestwich/clean-up
branch
from
3222713 to
c8c5f5d
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
319d8a7 to
4cccf9a
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
4cccf9a to
7333cc0
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
5d13c01 to
6dd9ee5
Compare
| import {PecorinoConstants} from "../chains/Pecorino.sol"; | ||
|
|
||
| abstract contract SignetL1 { | ||
| /// @notice Sentinal value for the native asset in order inputs/outputs |
There was a problem hiding this comment.
| /// @notice Sentinal value for the native asset in order inputs/outputs | |
| /// @notice Sentinel value for the native asset in order inputs/outputs |
| bool is7702; | ||
| assembly { | ||
| let ptr := mload(0x40) | ||
| extcodecopy(caller(), ptr, 0, 0x20) |
There was a problem hiding this comment.
this is kind of obscure, but isn't this a bug under a certain circumstance?
we check above for the correct code length on 7702 delegated addresses, but do the codecopy for prefix checking on caller, which IIRC, returns who is the call sender. So for any 7702 delegated user who uses an intermediary contract (e.g some router/defi thing) to call this, we'll return an aliased address instead of the EOA. shouldn't it be address()?
| ethToSignet(amount); | ||
| return; | ||
| } | ||
| IERC20(token).approve(address(PASSAGE), amount); |
There was a problem hiding this comment.
i think this might be problematic w/ USDT since they're non ERC20 compliant, and solidity tries to decode return data even if you don't use it. so this might straight up revert. we should use SafeERC20 here
Add an L1 contract for Signet users