fix(ci): resolve pytest hang after tests pass (loguru __del__ deadlock)#1
Merged
Merged
Conversation
… exit InteractiveContextParser.__del__ called loguru.remove() during GC of multiple parsers, re-entering loguru's handler lock and hanging after all tests passed. Replace with an explicit close() and restore spawn for ProcessPoolExecutor in language derivation. Co-authored-by: Arash Ashrafzadeh <arashmath16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI reported success (
191 passed, 2 skipped in ~4.5s) then stalled until the job timeout (~45 minutes). The hang occurs after pytest finishes, during interpreter shutdown.Root cause
InteractiveContextParser.__del__calledloguru.remove()for each parser's sinks. When several parsers with active logging are garbage-collected together (common after the loguru integration and increased parser usage from parallel language-derivation tests), loguru's internal lock is re-entered from nested__del__calls and the main thread deadlocks.This reproduces locally with:
Parallelisation/Rich/ProcessPoolExecutor mitigations on
mainwere reasonable hardening but did not fix this primary failure mode.Fix
__del__sink cleanup; add explicitclose()/_remove_icp_log_sinks().spawnmultiprocessing context forProcessPoolExecutorin language derivation (safe for real parallel runs outside pytest).Verification
uv run pytest -q→191 passed, 2 skippedand exit code 0 (previously hung with exit 124 undertimeout).