Skip to content

fix(aenv): pin transitive deps to coexist #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puzhen-ryan merged 1 commit into from
May 21, 2026
Merged

fix(aenv): pin transitive deps to coexist #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions aenv/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,16 @@ classifiers = [
]

dependencies = [
"pydantic>=1.10.0",
"pydantic>=2.7,<2.12",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning pydantic to a minor version upper bound (<2.12) is quite restrictive for a library and may cause dependency conflicts for downstream users who require newer versions of Pydantic (e.g., 2.12 or 2.13) in their own projects. If the intent is to avoid the pydantic-core 2.41 issue introduced in pydantic 2.13, consider using <2.13 to allow for more flexibility, unless 2.12 is also confirmed to be incompatible. Additionally, since moving from 1.10.0 to 2.7 is a major version jump that drops Pydantic v1 support, consider bumping the package version (e.g., to 0.2.0) to signal this breaking change to users.

"pydantic-settings>=2.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding pydantic-settings as a direct dependency seems redundant if it is not used directly by the aenv source code and is already pulled as a transitive dependency by mcp or fastmcp. Furthermore, without an upper bound, this entry does not help prevent the 'cascade' issue described in the PR if a newer version of pydantic-settings pulls in an incompatible pydantic version. If the goal is to control the version of this transitive dependency, an upper bound would be necessary, though the pin on pydantic itself (line 27) should already address the primary concern.

"httpx>=0.20.0",
"anyio>=3.0.0",
"typing-extensions>=4.0.0",
"mcp>=1.0.0",
"mcp>=1.0.0,<2",
"uvicorn>=0.20.0",
"click>=8.0.0",
"requests>=2.25.0",
"fastmcp>=2.13.0",
"fastmcp>=2.13.0,<3",
"rich>=13.0.0",
"typer>=0.9.0",
"tabulate>=0.9.0",
Expand Down
Loading