improve test coverage

Author: manu4543

src/url.ts

@@ -1,7 +1,6 @@
 import { UrlOptions } from "./interfaces";
 import { ImageOverlay, SolidColorOverlay, SubtitleOverlay, TextOverlay, Transformation, VideoOverlay } from "./interfaces/Transformation";
-import transformationUtils from "./utils/transformation";
-import { safeBtoa } from "./utils/transformation";
+import transformationUtils, { safeBtoa } from "./utils/transformation";
 const TRANSFORMATION_PARAMETER = "tr";
 const SIMPLE_OVERLAY_PATH_REGEX = new RegExp('^[a-zA-Z0-9-._/ ]*$')
 const SIMPLE_OVERLAY_TEXT_REGEX = new RegExp('^[a-zA-Z0-9-._ ]*$') // These characters are selected by testing actual URLs on both path and query parameters. If and when backend starts supporting wide range of characters, this regex should be updated to improve URL readability.
@@ -118,13 +117,11 @@ function processText(str: string, enccoding: TextOverlay["encoding"]): string {
 
 function processOverlay(overlay: Transformation["overlay"]): string | undefined {
   const entries = [];
-  if (!overlay) {
-    return;
-  }
-  const { type, position = {}, timing = {}, transformation = [] } = overlay;
+
+  const { type, position = {}, timing = {}, transformation = [] } = overlay || {};
 
   if (!type) {
-    throw new Error("Overlay type is required");
+    return;
   }
 
   switch (type) {

src/utils/transformation.ts

@@ -10,16 +10,9 @@ const TRANSFORM_DELIMITER: string = ",";
 const TRANSFORM_KEY_VALUE_DELIMITER: string = "-";
 
 export default {
-    getDefault: (): TransformationPosition => {
-        return DEFAULT_TRANSFORMATION_POSITION;
-    },
     addAsQueryParameter: (options: UrlOptions) => {
         return options.transformationPosition === QUERY_TRANSFORMATION_POSITION;
     },
-    validParameters: (options: UrlOptions) => {
-        if (typeof options.transformationPosition == "undefined") return false;
-        return VALID_TRANSFORMATION_POSITIONS.indexOf(options.transformationPosition) != -1;
-    },
     getTransformKey: function (transform: string) {
         if (!transform) { return ""; }
 
@@ -38,6 +31,7 @@ export default {
 
 export const safeBtoa = function (str: string): string {
     if (typeof window !== "undefined") {
+        /* istanbul ignore next */
         return btoa(str);
     } else {
         // Node fallback

test/url-generation/basic.js

@@ -12,7 +12,7 @@ describe("URL generation", function () {
         expect(url).equal("");
     });
 
-    it('should return an empty string for an invalid src URL', function () {
+    it('should return an empty string when src is /', function () {
         const url = buildURL({
             urlEndpoint: "https://ik.imagekit.io/test_url_endpoint",
             transformationPosition: "query",
@@ -22,6 +22,16 @@ describe("URL generation", function () {
         expect(url).equal("https://ik.imagekit.io/test_url_endpoint/");
     });
 
+    it('should return an empty string when src is invalid', function () {
+        const url = buildURL({
+            urlEndpoint: "https://ik.imagekit.io/test_url_endpoint",
+            transformationPosition: "query",
+            src: "https://"
+        });
+
+        expect(url).equal("");
+    });
+
     it('should generate a valid URL when src is provided without transformation', function () {
         const url = buildURL({
             urlEndpoint: "https://ik.imagekit.io/test_url_endpoint",

test/url-generation/overlay.js

@@ -19,6 +19,19 @@ describe("Overlay Transformation Test Cases", function () {
         expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/base-image.jpg`);
     });
 
+    it('Ignore if type is missing', function () {
+        const url = buildURL({
+            transformationPosition: "path",
+            urlEndpoint: "https://ik.imagekit.io/test_url_endpoint",
+            src: "/base-image.jpg",
+            transformation: [{
+                overlay: {
+                }
+            }]
+        });
+        expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/base-image.jpg`);
+    });
+
     it('Ignore invalid values if input (image)', function () {
         const url = buildURL({
             transformationPosition: "path",