From e7d6369213c2a2fe2e21de8e6663ecd03be075c9 Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Tue, 3 Feb 2026 12:13:38 +0100 Subject: [PATCH 1/4] Updated PHP versions in CI configuration to 8.3 and 8.4 --- .github/workflows/ci.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 0212f4458d..a11c80d718 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -43,8 +43,8 @@ jobs: matrix: php: - '7.4' - - '8.0' - - '8.1' + - '8.3' + - '8.4' steps: - uses: actions/checkout@v4 @@ -95,8 +95,8 @@ jobs: matrix: php: - '7.4' - - '8.0' - - '8.1' + - '8.3' + - '8.4' steps: - uses: actions/checkout@v3 @@ -150,8 +150,8 @@ jobs: matrix: php: - '7.4' - - '8.0' - - '8.1' + - '8.3' + - '8.4' steps: - uses: actions/checkout@v3 From c0a1da7c5bd317b0d250798e306ed07ffff26001 Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Tue, 3 Feb 2026 14:15:41 +0100 Subject: [PATCH 2/4] Updated nullable type hint for deleteNotification method and clean up phpstan baseline files --- phpstan-baseline-8.0.neon | 211 ------------------ phpstan-baseline.neon | 6 - phpstan-baseline.neon.php | 2 - src/lib/Form/Factory/FormFactory.php | 2 +- .../ContentInfoTransformerTest.php | 2 +- .../LanguageTransformerTest.php | 3 +- 6 files changed, 3 insertions(+), 223 deletions(-) delete mode 100644 phpstan-baseline-8.0.neon diff --git a/phpstan-baseline-8.0.neon b/phpstan-baseline-8.0.neon deleted file mode 100644 index 199f1d4121..0000000000 --- a/phpstan-baseline-8.0.neon +++ /dev/null @@ -1,211 +0,0 @@ -parameters: - ignoreErrors: - - - message: "#^Parameter \\#1 \\$array of function array_shift expects array, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Controller/Content/VersionDraftConflictController.php - - - - message: "#^Parameter \\#1 \\$array of function array_keys expects array, array\\|null given\\.$#" - count: 1 - path: src/bundle/Controller/ContentDraftController.php - - - - message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Controller/ContentTypeController.php - - - - message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/bundle/Controller/ContentTypeController.php - - - - message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/bundle/Controller/ContentTypeController.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Controller/ContentTypeGroupController.php - - - - message: "#^Parameter \\#1 \\$array of function array_shift expects array, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Controller/ContentViewController.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 1 - path: src/bundle/Controller/ContentViewController.php - - - - message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#" - count: 1 - path: src/bundle/Templating/Twig/UniversalDiscoveryExtension.php - - - - message: "#^Parameter \\#1 \\$object of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#" - count: 4 - path: src/lib/Behat/Component/Fields/DateAndTime.php - - - - message: "#^Parameter \\#1 \\$object of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#" - count: 4 - path: src/lib/Behat/Component/Fields/Time.php - - - - message: "#^Parameter \\#2 \\$offset of function substr expects int, int\\<0, max\\>\\|false given\\.$#" - count: 1 - path: src/lib/Behat/Page/RolePage.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/EventListener/ContentProxyCreateDraftListener.php - - - - message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" - count: 1 - path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php - - - - message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" - count: 1 - path: src/lib/Form/DataTransformer/FieldType/ImageAssetValueTransformer.php - - - - message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" - count: 1 - path: src/lib/Form/DataTransformer/FieldType/ImageValueTransformer.php - - - - message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" - count: 1 - path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/EventListener/AddLanguageFieldBasedOnContentListener.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/ChoiceList/Loader/AvailableTranslationLanguageChoiceLoader.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/ChoiceList/Loader/BaseTranslationLanguageChoiceLoader.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 2 - path: src/lib/Form/Type/ChoiceList/Loader/ContentEditTranslationChoiceLoader.php - - - - message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php - - - - message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php - - - - message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/Content/Translation/TranslationAddType.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/ContentType/Translation/TranslationAddType.php - - - - message: "#^Parameter \\#1 \\$string of function strtolower expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/Form/Type/FieldDefinition/User/PasswordConstraintCheckboxType.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Form/Type/ObjectState/ContentObjectStateUpdateType.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Pagination/Mapper/AbstractPagerContentToDataMapper.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 1 - path: src/lib/Permission/PermissionChecker.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Tab/Dashboard/PagerLocationToDataMapper.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/Tab/LocationView/ContentTab.php - - - - message: "#^Parameter \\#1 \\$string of function strtolower expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/Translation/Extractor/PolicyTranslationExtractor.php - - - - message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" - count: 1 - path: src/lib/UI/Config/Provider/ContentTypes.php - - - - message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/UI/Config/Provider/ContentTypes.php - - - - message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" - count: 1 - path: src/lib/UI/Config/Provider/ContentTypes.php - - - - message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" - count: 1 - path: src/lib/UI/Dataset/ContentDraftsDataset.php - - - - message: "#^Parameter \\#2 \\$length of function array_chunk expects int\\<1, max\\>, int given\\.$#" - count: 1 - path: src/lib/UI/Module/ContentTree/NodeFactory.php - - - - message: "#^Deprecated in PHP 8\\.0\\: Required parameter \\$translator follows optional parameter \\$name\\.$#" - count: 1 - path: tests/lib/Tab/TabRegistryTest.php - - - - message: "#^Deprecated in PHP 8\\.0\\: Required parameter \\$twig follows optional parameter \\$name\\.$#" - count: 1 - path: tests/lib/Tab/TabRegistryTest.php - - - - message: "#^Parameter \\#1 \\$iterator of function iterator_to_array expects Traversable, iterable\\ given\\.$#" - count: 1 - path: src/lib/Siteaccess/SiteaccessResolver.php - - - - message: "#^Parameter \\#1 \\$iterator of function iterator_to_array expects Traversable, iterable\\ given\\.$#" - count: 1 - path: tests/lib/Form/Data/ContentTypeDataTest.php diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index ed08d93477..9f575ee7c7 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -15370,12 +15370,6 @@ parameters: count: 1 path: tests/lib/Form/DataMapper/SelectionUpdateMapperTest.php - - - message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' - identifier: method.resultUnused - count: 1 - path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php - - message: '#^Method Ibexa\\Tests\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformerTest\:\:reverseTransformDataProvider\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue diff --git a/phpstan-baseline.neon.php b/phpstan-baseline.neon.php index da44dc862c..b8515693e1 100644 --- a/phpstan-baseline.neon.php +++ b/phpstan-baseline.neon.php @@ -9,8 +9,6 @@ $includes = []; if (PHP_VERSION_ID < 80000) { $includes[] = __DIR__ . '/phpstan-baseline-7.4.neon'; -} elseif (PHP_VERSION_ID < 80300) { - $includes[] = __DIR__ . '/phpstan-baseline-8.0.neon'; } else { $includes[] = __DIR__ . '/phpstan-baseline-8.3.neon'; } diff --git a/src/lib/Form/Factory/FormFactory.php b/src/lib/Form/Factory/FormFactory.php index ca74984688..8584b4421a 100644 --- a/src/lib/Form/Factory/FormFactory.php +++ b/src/lib/Form/Factory/FormFactory.php @@ -1071,7 +1071,7 @@ public function removeContentDraft( * @return \Symfony\Component\Form\FormInterface<\Ibexa\AdminUi\Form\Data\Notification\NotificationSelectionData|null> */ public function deleteNotification( - NotificationSelectionData $data = null, + ?NotificationSelectionData $data = null, ?string $name = null ): FormInterface { $name = $name ?: StringUtil::fqcnToBlockPrefix(NotificationSelectionType::class); diff --git a/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php b/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php index f30a3e59f4..ef5994aa33 100644 --- a/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php +++ b/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php @@ -49,7 +49,7 @@ public function testTransformWithInvalidInput($value): void $this->expectException(TransformationFailedException::class); $this->expectExceptionMessage('Expected a ' . ContentInfo::class . ' object.'); - $this->contentInfoTransformer->transform($value); + $result = $this->contentInfoTransformer->transform($value); } /** diff --git a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php index ac179e124a..33f30fd9e1 100644 --- a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php +++ b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php @@ -52,8 +52,7 @@ public function testTransformWithInvalidInput($value): void $this->expectException(TransformationFailedException::class); $this->expectExceptionMessage('Expected a ' . Language::class . ' object.'); - /** @phpstan-ignore method.resultUnused */ - $transformer->transform($value); + $result = $transformer->transform($value); } public function testReverseTransformWithLanguageCode(): void From 21d66d96588c2db1325a4dff7a0c119ccb670989 Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Thu, 5 Feb 2026 14:19:36 +0100 Subject: [PATCH 3/4] Suppress unused result warnings in transformation tests --- phpstan-baseline.neon | 6 ++++++ .../lib/Form/DataTransformer/ContentInfoTransformerTest.php | 2 +- tests/lib/Form/DataTransformer/LanguageTransformerTest.php | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 9f575ee7c7..ed08d93477 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -15370,6 +15370,12 @@ parameters: count: 1 path: tests/lib/Form/DataMapper/SelectionUpdateMapperTest.php + - + message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' + identifier: method.resultUnused + count: 1 + path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php + - message: '#^Method Ibexa\\Tests\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformerTest\:\:reverseTransformDataProvider\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue diff --git a/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php b/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php index ef5994aa33..f30a3e59f4 100644 --- a/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php +++ b/tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php @@ -49,7 +49,7 @@ public function testTransformWithInvalidInput($value): void $this->expectException(TransformationFailedException::class); $this->expectExceptionMessage('Expected a ' . ContentInfo::class . ' object.'); - $result = $this->contentInfoTransformer->transform($value); + $this->contentInfoTransformer->transform($value); } /** diff --git a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php index 33f30fd9e1..ac179e124a 100644 --- a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php +++ b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php @@ -52,7 +52,8 @@ public function testTransformWithInvalidInput($value): void $this->expectException(TransformationFailedException::class); $this->expectExceptionMessage('Expected a ' . Language::class . ' object.'); - $result = $transformer->transform($value); + /** @phpstan-ignore method.resultUnused */ + $transformer->transform($value); } public function testReverseTransformWithLanguageCode(): void From 366f476de1484d86bc2e477251b639fb258450cb Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Fri, 6 Feb 2026 12:08:46 +0100 Subject: [PATCH 4/4] Renamed ci.yaml to backend-ci.yaml and update PHPStan baseline files for PHP 8.4 compatibility --- .../workflows/{ci.yaml => backend-ci.yaml} | 0 phpstan-baseline-7.4.neon | 12 ++ phpstan-baseline-8.3.neon | 12 ++ phpstan-baseline-8.4.neon | 201 ++++++++++++++++++ phpstan-baseline.neon | 6 - phpstan-baseline.neon.php | 4 +- .../LanguageTransformerTest.php | 1 - 7 files changed, 228 insertions(+), 8 deletions(-) rename .github/workflows/{ci.yaml => backend-ci.yaml} (100%) create mode 100644 phpstan-baseline-8.4.neon diff --git a/.github/workflows/ci.yaml b/.github/workflows/backend-ci.yaml similarity index 100% rename from .github/workflows/ci.yaml rename to .github/workflows/backend-ci.yaml diff --git a/phpstan-baseline-7.4.neon b/phpstan-baseline-7.4.neon index beddd115ca..53fa25bae8 100644 --- a/phpstan-baseline-7.4.neon +++ b/phpstan-baseline-7.4.neon @@ -282,3 +282,15 @@ parameters: identifier: argument.type count: 1 path: src/bundle/Templating/Twig/UniversalDiscoveryExtension.php + + - + message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\LanguageTransformer\:\:transform\(\) on a separate line has no effect\.$#' + identifier: method.resultUnused + count: 1 + path: tests/lib/Form/DataTransformer/LanguageTransformerTest.php + + - + message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' + identifier: method.resultUnused + count: 1 + path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php diff --git a/phpstan-baseline-8.3.neon b/phpstan-baseline-8.3.neon index 9c45740199..7ebbd5bbb2 100644 --- a/phpstan-baseline-8.3.neon +++ b/phpstan-baseline-8.3.neon @@ -199,3 +199,15 @@ parameters: message: "#^Deprecated in PHP 8\\.0\\: Required parameter \\$twig follows optional parameter \\$name\\.$#" count: 1 path: tests/lib/Tab/TabRegistryTest.php + + - + message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\LanguageTransformer\:\:transform\(\) on a separate line has no effect\.$#' + identifier: method.resultUnused + count: 1 + path: tests/lib/Form/DataTransformer/LanguageTransformerTest.php + + - + message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' + identifier: method.resultUnused + count: 1 + path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php diff --git a/phpstan-baseline-8.4.neon b/phpstan-baseline-8.4.neon new file mode 100644 index 0000000000..9c45740199 --- /dev/null +++ b/phpstan-baseline-8.4.neon @@ -0,0 +1,201 @@ +parameters: + ignoreErrors: + - + message: "#^Parameter \\#1 \\$array of function array_shift expects array, iterable\\ given\\.$#" + count: 1 + path: src/bundle/Controller/Content/VersionDraftConflictController.php + + - + message: "#^Parameter \\#1 \\$array of function array_keys expects array, array\\|null given\\.$#" + count: 1 + path: src/bundle/Controller/ContentDraftController.php + + - + message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" + count: 1 + path: src/bundle/Controller/ContentTypeController.php + + - + message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/bundle/Controller/ContentTypeController.php + + - + message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/bundle/Controller/ContentTypeController.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" + count: 1 + path: src/bundle/Controller/ContentTypeGroupController.php + + - + message: "#^Parameter \\#1 \\$array of function array_shift expects array, iterable\\ given\\.$#" + count: 1 + path: src/bundle/Controller/ContentViewController.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" + count: 1 + path: src/bundle/Controller/ContentViewController.php + + - + message: "#^Parameter \\#1 \\$separator of function explode expects non\\-empty\\-string, string given\\.$#" + count: 1 + path: src/bundle/Templating/Twig/UniversalDiscoveryExtension.php + + - + message: "#^Parameter \\#1 \\$object of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#" + count: 4 + path: src/lib/Behat/Component/Fields/DateAndTime.php + + - + message: "#^Parameter \\#1 \\$object of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#" + count: 4 + path: src/lib/Behat/Component/Fields/Time.php + + - + message: "#^Parameter \\#2 \\$offset of function substr expects int, int\\<0, max\\>\\|false given\\.$#" + count: 1 + path: src/lib/Behat/Page/RolePage.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/EventListener/ContentProxyCreateDraftListener.php + + - + message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" + count: 1 + path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php + + - + message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" + count: 1 + path: src/lib/Form/DataTransformer/FieldType/ImageAssetValueTransformer.php + + - + message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" + count: 1 + path: src/lib/Form/DataTransformer/FieldType/ImageValueTransformer.php + + - + message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|null given\\.$#" + count: 1 + path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/EventListener/AddLanguageFieldBasedOnContentListener.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/ChoiceList/Loader/AvailableTranslationLanguageChoiceLoader.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/ChoiceList/Loader/BaseTranslationLanguageChoiceLoader.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 2 + path: src/lib/Form/Type/ChoiceList/Loader/ContentEditTranslationChoiceLoader.php + + - + message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php + + - + message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php + + - + message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/Content/Translation/TranslationAddType.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/ContentType/Translation/TranslationAddType.php + + - + message: "#^Parameter \\#1 \\$string of function strtolower expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/Form/Type/FieldDefinition/User/PasswordConstraintCheckboxType.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Form/Type/ObjectState/ContentObjectStateUpdateType.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Pagination/Mapper/AbstractPagerContentToDataMapper.php + + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" + count: 1 + path: src/lib/Permission/PermissionChecker.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Tab/Dashboard/PagerLocationToDataMapper.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/Tab/LocationView/ContentTab.php + + - + message: "#^Parameter \\#1 \\$string of function strtolower expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/Translation/Extractor/PolicyTranslationExtractor.php + + - + message: "#^Parameter \\#1 \\$array of function usort expects TArray of array\\, iterable\\ given\\.$#" + count: 1 + path: src/lib/UI/Config/Provider/ContentTypes.php + + - + message: "#^Parameter \\#1 \\$string1 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/UI/Config/Provider/ContentTypes.php + + - + message: "#^Parameter \\#2 \\$string2 of function strnatcasecmp expects string, string\\|null given\\.$#" + count: 1 + path: src/lib/UI/Config/Provider/ContentTypes.php + + - + message: "#^Parameter \\#1 \\$array of function array_filter expects array, iterable\\ given\\.$#" + count: 1 + path: src/lib/UI/Dataset/ContentDraftsDataset.php + + - + message: "#^Parameter \\#2 \\$length of function array_chunk expects int\\<1, max\\>, int given\\.$#" + count: 1 + path: src/lib/UI/Module/ContentTree/NodeFactory.php + + - + message: "#^Deprecated in PHP 8\\.0\\: Required parameter \\$translator follows optional parameter \\$name\\.$#" + count: 1 + path: tests/lib/Tab/TabRegistryTest.php + + - + message: "#^Deprecated in PHP 8\\.0\\: Required parameter \\$twig follows optional parameter \\$name\\.$#" + count: 1 + path: tests/lib/Tab/TabRegistryTest.php diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index ed08d93477..9f575ee7c7 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -15370,12 +15370,6 @@ parameters: count: 1 path: tests/lib/Form/DataMapper/SelectionUpdateMapperTest.php - - - message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' - identifier: method.resultUnused - count: 1 - path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php - - message: '#^Method Ibexa\\Tests\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformerTest\:\:reverseTransformDataProvider\(\) return type has no value type specified in iterable type array\.$#' identifier: missingType.iterableValue diff --git a/phpstan-baseline.neon.php b/phpstan-baseline.neon.php index b8515693e1..4fc0d69823 100644 --- a/phpstan-baseline.neon.php +++ b/phpstan-baseline.neon.php @@ -9,8 +9,10 @@ $includes = []; if (PHP_VERSION_ID < 80000) { $includes[] = __DIR__ . '/phpstan-baseline-7.4.neon'; -} else { +} else if (PHP_VERSION_ID < 80400) { $includes[] = __DIR__ . '/phpstan-baseline-8.3.neon'; +} else { + $includes[] = __DIR__ . '/phpstan-baseline-8.4.neon'; } $config = []; diff --git a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php index ac179e124a..3ed4884700 100644 --- a/tests/lib/Form/DataTransformer/LanguageTransformerTest.php +++ b/tests/lib/Form/DataTransformer/LanguageTransformerTest.php @@ -52,7 +52,6 @@ public function testTransformWithInvalidInput($value): void $this->expectException(TransformationFailedException::class); $this->expectExceptionMessage('Expected a ' . Language::class . ' object.'); - /** @phpstan-ignore method.resultUnused */ $transformer->transform($value); }