From 76b23183de2bab3da4457907699c34097014eb1e Mon Sep 17 00:00:00 2001
From: Lorenzo Delana <lorenzo.delana@gmail.com>
Date: Sun, 9 Apr 2023 15:25:07 +0200
Subject: [PATCH 1/4] update netstandard to 2.1 and net framework to net7

---
 ColorHelper.ConsoleDemo/ColorHelper.ConsoleDemo.csproj | 2 +-
 ColorHelper.Tests/ColorHelper.Tests.csproj             | 2 +-
 ColorHelper/ColorHelper.csproj                         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ColorHelper.ConsoleDemo/ColorHelper.ConsoleDemo.csproj b/ColorHelper.ConsoleDemo/ColorHelper.ConsoleDemo.csproj
index cbf85b0..2c9b6d2 100644
--- a/ColorHelper.ConsoleDemo/ColorHelper.ConsoleDemo.csproj
+++ b/ColorHelper.ConsoleDemo/ColorHelper.ConsoleDemo.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net7</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/ColorHelper.Tests/ColorHelper.Tests.csproj b/ColorHelper.Tests/ColorHelper.Tests.csproj
index 9707c7c..2cf2b30 100644
--- a/ColorHelper.Tests/ColorHelper.Tests.csproj
+++ b/ColorHelper.Tests/ColorHelper.Tests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net7</TargetFramework>
 
     <IsPackable>false</IsPackable>
 
diff --git a/ColorHelper/ColorHelper.csproj b/ColorHelper/ColorHelper.csproj
index 3568d8b..42e04aa 100644
--- a/ColorHelper/ColorHelper.csproj
+++ b/ColorHelper/ColorHelper.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFramework>netstandard2.1</TargetFramework>
     <Authors>Artyom Gritsuk</Authors>
     <RepositoryUrl>https://github.com/iamartyom/ColorHelper</RepositoryUrl>
     <PackageProjectUrl>https://github.com/iamartyom/ColorHelper</PackageProjectUrl>

From b006b3f3d6f925e3a5736062298d7a81c99f591b Mon Sep 17 00:00:00 2001
From: Lorenzo Delana <lorenzo.delana@gmail.com>
Date: Sun, 9 Apr 2023 15:26:22 +0200
Subject: [PATCH 2/4] failing unit test that convert hsv(270,100,100) to
 rgb(127,0,255) instead of expected (128,0,255)

---
 ColorHelper.Tests/Converter/ColorConverter.cs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ColorHelper.Tests/Converter/ColorConverter.cs b/ColorHelper.Tests/Converter/ColorConverter.cs
index 91d71f9..ffc77b6 100644
--- a/ColorHelper.Tests/Converter/ColorConverter.cs
+++ b/ColorHelper.Tests/Converter/ColorConverter.cs
@@ -120,6 +120,9 @@ public void HsvToRgb()
         {
             var result = ColorConverter.HsvToRgb(new HSV(240, 80, 64));
             Assert.AreEqual(new RGB(32, 32, 162), result);
+
+            result = ColorConverter.HsvToRgb(new HSV(270, 100, 100));
+            Assert.AreEqual(new RGB(128, 0, 255), result);
         }
 
         [Test]

From 0ffc05576d7814aae343669181df678a67418ce5 Mon Sep 17 00:00:00 2001
From: Lorenzo Delana <lorenzo.delana@gmail.com>
Date: Sun, 9 Apr 2023 15:45:51 +0200
Subject: [PATCH 3/4] fix rounding in hsl to rgb

---
 ColorHelper/Converter/ColorConverter.cs | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/ColorHelper/Converter/ColorConverter.cs b/ColorHelper/Converter/ColorConverter.cs
index f7dfd83..63f8595 100644
--- a/ColorHelper/Converter/ColorConverter.cs
+++ b/ColorHelper/Converter/ColorConverter.cs
@@ -270,9 +270,12 @@ public static RGB HslToRgb(HSL hsl)
                 r = modifiedL;
                 g = modifiedL;
                 b = modifiedL;
-            }
-
-            return new RGB((byte)Math.Round(r * 255), (byte)Math.Round(g * 255), (byte)Math.Round(b * 255));
+            }      
+            
+            return new RGB(
+                (byte)Math.Round(Math.Round(r * 255, 1)), 
+                (byte)Math.Round(Math.Round(g * 255, 1)),
+                (byte)Math.Round(Math.Round(b * 255, 1)));
         }
 
         private static double GetHue(double p, double q, double t)

From 25d45bc6d3a99332c6b61761c4bca829fa5f0f42 Mon Sep 17 00:00:00 2001
From: Lorenzo Delana <lorenzo.delana@gmail.com>
Date: Fri, 14 Apr 2023 19:32:29 +0200
Subject: [PATCH 4/4] revert to netstandard2.0

---
 ColorHelper/ColorHelper.csproj | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ColorHelper/ColorHelper.csproj b/ColorHelper/ColorHelper.csproj
index 42e04aa..3568d8b 100644
--- a/ColorHelper/ColorHelper.csproj
+++ b/ColorHelper/ColorHelper.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Authors>Artyom Gritsuk</Authors>
     <RepositoryUrl>https://github.com/iamartyom/ColorHelper</RepositoryUrl>
     <PackageProjectUrl>https://github.com/iamartyom/ColorHelper</PackageProjectUrl>