style: add missing final keyword and formatting improvements (#660)

Author: jbern0rd

src/main/java/com/iexec/worker/compute/app/AppComputeService.java

@@ -115,11 +115,11 @@ public AppComputeResponse runCompute(final TaskDescription taskDescription,
     // We use the name "worker1-0xabc123" for app container to avoid
     // conflicts when running multiple workers on the same machine.
     // Exp: integration tests
-    private String getTaskContainerName(String chainTaskId) {
+    private String getTaskContainerName(final String chainTaskId) {
         return workerConfigService.getWorkerName() + "-" + chainTaskId;
     }
 
-    private List<ReplicateStatusCause> getExitCauseFromFinalStatus(DockerRunFinalStatus finalStatus) {
+    private List<ReplicateStatusCause> getExitCauseFromFinalStatus(final DockerRunFinalStatus finalStatus) {
         return switch (finalStatus) {
             case TIMEOUT -> List.of(ReplicateStatusCause.APP_COMPUTE_TIMEOUT);
             case FAILED -> List.of(ReplicateStatusCause.APP_COMPUTE_FAILED);

src/main/java/com/iexec/worker/compute/post/PostComputeService.java

@@ -211,18 +211,17 @@ public PostComputeResponse runTeePostCompute(TaskDescription taskDescription,
         }
         final DockerRunFinalStatus finalStatus = dockerResponse.getFinalStatus();
         if (finalStatus == DockerRunFinalStatus.TIMEOUT) {
-            log.error("Tee post-compute container timed out" +
-                            " [chainTaskId:{}, maxExecutionTime:{}]",
+            log.error("Tee post-compute container timed out [chainTaskId:{}, maxExecutionTime:{}]",
                     chainTaskId, taskDescription.getMaxExecutionTime());
             return PostComputeResponse.builder()
                     .exitCauses(List.of(ReplicateStatusCause.POST_COMPUTE_TIMEOUT))
                     .build();
         }
         if (finalStatus == DockerRunFinalStatus.FAILED) {
-            int exitCode = dockerResponse.getContainerExitCode();
+            final int exitCode = dockerResponse.getContainerExitCode();
             final List<ReplicateStatusCause> exitCauses = getExitCauses(chainTaskId, exitCode);
-            log.error("Failed to run tee post-compute [chainTaskId:{}, " +
-                    "exitCode:{}, exitCauses:{}]", chainTaskId, exitCode, exitCauses);
+            log.error("Failed to run tee post-compute [chainTaskId:{}, exitCode:{}, exitCauses:{}]",
+                    chainTaskId, exitCode, exitCauses);
             return PostComputeResponse.builder()
                     .exitCauses(exitCauses)
                     .build();

src/main/java/com/iexec/worker/compute/pre/PreComputeResponse.java

@@ -35,7 +35,6 @@ public class PreComputeResponse implements ComputeResponse {
     String stdout;
     String stderr;
 
-
     @Override
     public boolean isSuccessful() {
         if (isTeeTask) {

src/main/java/com/iexec/worker/compute/pre/PreComputeService.java

@@ -117,8 +117,7 @@ public PreComputeResponse runTeePreCompute(TaskDescription taskDescription, Work
                 .ofGigabytes(workerConfigService.getTeeComputeMaxHeapSizeGb())
                 .toBytes();
         if (enclaveConfig.getHeapSize() > teeComputeMaxHeapSize) {
-            log.error("Enclave configuration should define a proper heap " +
-                            "size [chainTaskId:{}, heapSize:{}, maxHeapSize:{}]",
+            log.error("Enclave configuration should define a proper heap size [chainTaskId:{}, heapSize:{}, maxHeapSize:{}]",
                     chainTaskId, enclaveConfig.getHeapSize(), teeComputeMaxHeapSize);
             preComputeResponseBuilder.exitCauses(List.of(PRE_COMPUTE_INVALID_ENCLAVE_HEAP_CONFIGURATION));
             return preComputeResponseBuilder.build();
@@ -140,8 +139,8 @@ public PreComputeResponse runTeePreCompute(TaskDescription taskDescription, Work
 
         // run TEE pre-compute container if needed
         if (taskDescription.requiresPreCompute()) {
-            log.info("Task contains TEE input data [chainTaskId:{}, containsDataset:{}, containsInputFiles:{}]",
-                    chainTaskId, taskDescription.containsDataset(), taskDescription.containsInputFiles());
+            log.info("Task contains TEE input data [chainTaskId:{}, containsDataset:{}, containsInputFiles:{}, isBulkRequest:{}]",
+                    chainTaskId, taskDescription.containsDataset(), taskDescription.containsInputFiles(), taskDescription.isBulkRequest());
             final List<ReplicateStatusCause> exitCauses = downloadDatasetAndFiles(taskDescription, secureSession);
             preComputeResponseBuilder.exitCauses(exitCauses);
         }
@@ -150,12 +149,12 @@ public PreComputeResponse runTeePreCompute(TaskDescription taskDescription, Work
     }
 
     private List<ReplicateStatusCause> downloadDatasetAndFiles(
-            TaskDescription taskDescription,
-            TeeSessionGenerationResponse secureSession) {
+            final TaskDescription taskDescription,
+            final TeeSessionGenerationResponse secureSession) {
         try {
-            Integer exitCode = prepareTeeInputData(taskDescription, secureSession);
+            final Integer exitCode = prepareTeeInputData(taskDescription, secureSession);
             if (exitCode == null || exitCode != 0) {
-                String chainTaskId = taskDescription.getChainTaskId();
+                final String chainTaskId = taskDescription.getChainTaskId();
                 final List<ReplicateStatusCause> exitCauses = getExitCauses(chainTaskId, exitCode);
                 log.error("Failed to prepare TEE input data [chainTaskId:{}, exitCode:{}, exitCauses:{}]",
                         chainTaskId, exitCode, exitCauses);

src/main/java/com/iexec/worker/result/ResultService.java

@@ -101,8 +101,7 @@ public boolean writeErrorToIexecOut(final String chainTaskId, final ReplicateSta
         final String errorContent = String.format("[IEXEC] Errors occurred while computing the task [error:%s, causes:%s]",
                 errorStatus, causes);
         final ComputedFile computedFile = ComputedFile.builder()
-                .deterministicOutputPath(IexecFileHelper.SLASH_IEXEC_OUT +
-                        File.separator + ERROR_FILENAME)
+                .deterministicOutputPath(IexecFileHelper.SLASH_IEXEC_OUT + File.separator + ERROR_FILENAME)
                 .build();
         final String computedFileJsonAsString;
         try {