fix: deprecate SGX SCONE and propose migration to TDX when possible (#269)

Author: PierreJeanjacquot

cli/src/cmd/deploy.ts

@@ -20,7 +20,7 @@ import { askForWallet } from '../cli-helpers/askForWallet.js';
 import { getIExec } from '../utils/iexec.js';
 import { goToProjectRoot } from '../cli-helpers/goToProjectRoot.js';
 import * as color from '../cli-helpers/color.js';
-import { hintBox } from '../cli-helpers/box.js';
+import { hintBox, warnBox } from '../cli-helpers/box.js';
 import { addDeploymentData } from '../utils/cacheExecutions.js';
 import { useTdx } from '../utils/featureFlags.js';
 import { ensureBalances } from '../cli-helpers/ensureBalances.js';
@@ -37,24 +37,47 @@ export async function deploy({ chain }: { chain?: string }) {
       defaultChain,
       spinner,
     });
-    await warnBeforeTxFees({ spinner, chain: chainConfig.name });
-
-    const signer = await askForWallet({ spinner });
-    const userAddress = await signer.getAddress();
 
     // initialize iExec
-    const iexec = getIExec({ ...chainConfig, signer });
+    const iexecReadonly = getIExec({ ...chainConfig });
     // determine TEE framework based on feature flag
     const teeFramework = useTdx ? 'tdx' : 'scone';
     // check TEE framework compatibility with selected chain
     try {
-      await iexec.config.resolveSmsURL({ teeFramework });
+      await iexecReadonly.config.resolveSmsURL({ teeFramework });
     } catch {
       throw new Error(
         `TEE framework ${teeFramework.toUpperCase()} is not supported on the selected chain`
       );
     }
 
+    if (teeFramework === 'scone') {
+      try {
+        await iexecReadonly.config.resolveSmsURL({ teeFramework: 'tdx' });
+        spinner.log(
+          warnBox(
+            `SGX SCONE TEE framework is deprecated in favor of TDX and will be removed in future versions.
+Please consider redeploying your app with TDX instead.
+        
+run ${color.command('EXPERIMENTAL_TDX_APP=1 iapp deploy')} to deploy your app with TDX now.`
+          )
+        );
+      } catch {
+        spinner.warn(
+          'SGX SCONE TEE framework is deprecated and will be removed in a future version, please contact iExec support to know more about TDX and how to migrate your app.'
+        );
+      }
+    }
+
+    await warnBeforeTxFees({ spinner, chain: chainConfig.name });
+
+    const signer = await askForWallet({ spinner });
+    const userAddress = await signer.getAddress();
+
+    // initialize iExec
+    const iexec = getIExec({ ...chainConfig, signer });
+    // determine TEE framework based on feature flag
+
     await ensureBalances({ spinner, iexec, warnOnlyRlc: true });
 
     const dockerhubUsername = await askForDockerhubUsername({ spinner });

cli/src/cmd/run.ts

@@ -19,6 +19,7 @@ import { ensureBalances } from '../cli-helpers/ensureBalances.js';
 import { askForAcknowledgment } from '../cli-helpers/askForAcknowledgment.js';
 import { warnBeforeTxFees } from '../cli-helpers/warnBeforeTxFees.js';
 import { resolveChainConfig } from '../cli-helpers/resolveChainConfig.js';
+import { warnBox } from '../cli-helpers/box.js';
 
 export async function run({
   iAppAddress,
@@ -46,7 +47,6 @@ export async function run({
       defaultChain,
       spinner,
     });
-    await warnBeforeTxFees({ spinner, chain: chainConfig.name });
 
     spinner.start('checking inputs...');
     // initialize iExec
@@ -70,6 +70,24 @@ export async function run({
       );
     }
 
+    if (teeFramework === 'scone') {
+      try {
+        await readOnlyIexec.config.resolveSmsURL({ teeFramework: 'tdx' });
+        spinner.log(
+          warnBox(
+            `SGX SCONE TEE framework is deprecated in favor of TDX and will be removed in future versions.
+Please consider redeploying your app with TDX instead.
+            
+run ${color.command('EXPERIMENTAL_TDX_APP=1 iapp deploy')} to redeploy your app with TDX.`
+          )
+        );
+      } catch {
+        spinner.warn(
+          'SGX SCONE TEE framework is deprecated and will be removed in a future version, please contact iExec support to know more about TDX and how to migrate your app.'
+        );
+      }
+    }
+
     if (protectedData.length > 0) {
       await Promise.all(
         protectedData.map(async (dataset) => {
@@ -92,6 +110,8 @@ export async function run({
       );
     }
 
+    await warnBeforeTxFees({ spinner, chain: chainConfig.name });
+
     // Get wallet from privateKey
     const signer = await askForWallet({ spinner });
     const userAddress = await signer.getAddress();