WIP #84

Author: catmando

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/collection.rb

@@ -86,7 +86,7 @@ def ==(other_collection)
       # https://github.com/hyperstack-org/hyperstack/issues/84
       # the following seems wrong.  It results in loading collection (i.e. @collection is nil) being equal to anything that is not a collection!!!
       # TODO: try changing to something more robust like `return (@collection || []) == other_collection unless other_collection.is_a? collection
-      return !@collection unless other_collection.is_a? Collection
+      return (@collection || []) == other_collection unless other_collection.is_a? Collection
       other_collection.observed
       # if either collection has not been created then compare the vectors
       # https://github.com/hyperstack-org/hyperstack/issues/81

ruby/hyper-model/spec/batch4/scope_spec.rb

@@ -417,9 +417,9 @@ class << self
     end
     # https://github.com/hyperstack-org/hyperstack/issues/84
     # currently page will initially show that @scope == @previous_scope even though
-    # previous scope is nil
-    # page.should have_content('current scope != previous_scope')
-    binding.pry
+    #   previous scope is nil
+    # once issue 84 is fixed uncomment the following line
+    page.should have_content('current scope != previous_scope')
     evaluate_ruby do
       TestComponent2.scope = :active
     end