closes #196 and cleans up install docs and generator

Author: catmando

docs/installation/installation.md

@@ -8,9 +8,14 @@ For any setup you need
 
 #### - Rails 5.x ([Install Instructions](http://railsinstaller.org/en))
 
+> if anybody can confirm or deny that NodeJS is actually needed for a basic install just to
+display a component, please let us know by either chatting, tweeting #hyperstack, or raising an issue.
+
 And for a full system that includes Webpack for managing javascript assets you will need
 
-#### - Yarn ([Install Instructions](https://yarnpkg.com/en/docs/install#mac-stable))
+#### - Yarn ([Install Instructions](https://yarnpkg.com/en/docs/install))
+#### - NodeJS: ([Install Instructions](https://nodejs.org))
+
 
 ## Creating a Test Rails App
 
@@ -305,7 +310,9 @@ work the same, but just generate different skeleton components.
 
 Using the Rails `webpacker` gem you can easily add other NPM (node package manager) assets to your Hyperstack application.  This allows your Hyperstack components to use any of the thousands of existing React component libraries, as well as packages like jQuery.
 
-> Note that you will need to have yarn installed: [Install Instructions](https://yarnpkg.com/en/docs/install#mac-stable)
+> Note that you will need to have yarn and nodejs installed:  
+> [Yarn Install Instructions](https://yarnpkg.com/en/docs/install)  
+> [Node Install Instructions](https://nodejs.org)
 
 For details on how to import and use NPM packages in your application see [Importing React Components](https://hyperstack.org/edge/docs/dsl-client/components#javascript-components)
 
@@ -322,12 +329,13 @@ This will do the following:
 
 These steps are explained in detailed below.
 
-#### Yarn
+#### Yarn and Node
 
 Yarn is an NPM package manager.  Its role is similar to bundler in the Ruby world.  Like bundler it uses a `.lock` file to track the current set of dependencies.  Unlike
-bundler there is no equivilent of the `Gem` file.  Instead you add packages directly into the yarn data base by running `yarn add` commands.
+bundler there is no equivilent of the `Gem` file.  Instead you add packages directly into the yarn data base by running `yarn add` commands.  Yarn also depends on NodeJS so you will need to install that if you have not already.
 
-Yarn can be installed following these instructions: [Install Instructions](https://yarnpkg.com/en/docs/install#mac-stable)
+Yarn can be installed following these instructions: [Install Instructions](https://yarnpkg.com/en/docs/install#mac-stable)  
+Node can be installed following these instructions: [Node Install Instructions](https://nodejs.org)
 
 #### The Webpacker Gem
 

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/collection.rb

@@ -588,25 +588,8 @@ def loading?
       @dummy_collection.loading?
     end
 
-    # def loading?
-    #   !@collection || (@dummy_collection && @dummy_collection.loading?) || (@owner && !@owner.id && @vector && @vector.length <= 1)
-    # end
-
-    # def loaded?
-    #   @collection && (!@dummy_collection || !@dummy_collection.loading?) && (!@owner || @owner.id || !@vector || @vector.length > 1)
-    #   #false && @collection && (!@dummy_collection || !@dummy_collection.loading?) && (!@owner || @owner.id || @vector.length > 1)
-    # end
-
-    def empty?
-      # should be handled by method missing below, but opal-rspec does not deal well
-      # with method missing, so to test...
-      all.empty?
-    end
-
     def find_by(attrs)
       attrs = @target_klass.__hyperstack_preprocess_attrs(attrs)
-      # r = @collection&.detect { |lr| lr.new_record? && !attrs.detect { |k, v| lr.attributes[k] != v } }
-      # return r if r
       (r = __hyperstack_internal_scoped_find_by(attrs)) || return
       r.backing_record.sync_attributes(attrs).set_ar_instance!
     end
@@ -627,6 +610,16 @@ def _find_by_initializer(scope, attrs)
       found
     end
 
+    # to avoid fetching the entire collection array we check empty and any against the count
+
+    def empty?
+      count.zero?
+    end
+
+    def any?
+      !count.zero?
+    end
+
     def method_missing(method, *args, &block)
       if args.count == 1 && method.start_with?('find_by_')
         find_by(method.sub(/^find_by_/, '') => args[0])

ruby/hyper-model/spec/batch2/collection_aggregate_methods_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+require 'test_components'
+require 'rspec-steps'
+
+RSpec::Steps.steps "collection aggregate methods", js: true do
+
+  before(:all) do
+    require 'pusher'
+    require 'pusher-fake'
+    Pusher.app_id = "MY_TEST_ID"
+    Pusher.key =    "MY_TEST_KEY"
+    Pusher.secret = "MY_TEST_SECRET"
+    require "pusher-fake/support/base"
+
+    Hyperstack.configuration do |config|
+      config.transport = :pusher
+      config.channel_prefix = "synchromesh"
+      config.opts = {app_id: Pusher.app_id, key: Pusher.key, secret: Pusher.secret}.merge(PusherFake.configuration.web_options)
+    end
+  end
+
+  before(:step) do
+    # spec_helper resets the policy system after each test so we have to setup
+    # before each test
+    stub_const 'TestApplication', Class.new
+    stub_const 'TestApplicationPolicy', Class.new
+    TestApplicationPolicy.class_eval do
+      always_allow_connection
+      regulate_all_broadcasts { |policy| policy.send_all }
+      allow_change(to: :all, on: [:create, :update, :destroy]) { true }
+    end
+    size_window(:small, :portrait)
+  end
+
+  [:count, :empty?, :any?].each do |method|
+    it "will not retrieve the entire collection when using #{method}" do
+      FactoryBot.create(:test_model)
+
+      expect_promise(<<-RUBY
+        Hyperstack::Model
+        .load { TestModel.#{method} }
+        .then do |val|
+          if TestModel.all.instance_variable_get('@collection')
+            "unnecessary fetch of all"
+          else
+            val
+          end
+        end
+      RUBY
+    ).to eq(TestModel.all.send(method))
+    end
+  end
+end

ruby/rails-hyperstack/lib/generators/hyperstack/install_generator.rb

@@ -43,7 +43,7 @@ def insure_yarn_loaded
         yarn_version = `yarn --version`
         raise Errno::ENOENT if yarn_version.blank?
       rescue Errno::ENOENT
-        raise Thor::Error.new("please insure the yarn command is available if using webpacker")
+        raise Thor::Error.new("please insure nodejs is installed and the yarn command is available if using webpacker")
       end
     end
 

ruby/rails-hyperstack/rails-hyperstack.gemspec

@@ -25,11 +25,11 @@ Welcome to Hyperstack!
 
 For a quick start simply add a component using one of the generators:
 
-  >> bundle exec rails generate hyper:component CompName --add-route=/test/(*others)
+  >> bundle exec rails generate hyper:component CompName --add-route="/test/(*others)"
      # Add a new component named CompName and route to it with /test/
 
-  >> bundle exec rails generate hyper:router CompName --add-route=/test/(*others)
-     # Add a top level router named CompName
+  >> bundle exec rails generate hyper:router CompName --add-route="/test/(*others)"
+     # Add a top level router named CompName and route to it
 
 The generators will insure you have the minimal additions to your system for the
 new component to run.  And note: --add-route is optional.