Untrack vendored BuckleScript artifacts (#33 stage 1)#34
Merged
Conversation
The 248 generated files under gui/lib/rescript-{d3,webapi}/lib/{bs,ocaml}/
(.ast/.iast/.ninja) are compiled output of vendored ReScript libraries
and are already covered by .gitignore, but were committed before being
ignored. Remove them from version control (kept on disk); they will no
longer be re-added. Groundwork for the ReScript -> AffineScript epic.
https://claude.ai/code/session_01LKw5BvbbxFUWi9YMogGJTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 1 of #33 (ReScript → AffineScript epic) — the safe, immediate part.
Removes 248 vendored BuckleScript build artifacts from version control:
gui/lib/rescript-d3/lib/{bs,ocaml}/andgui/lib/rescript-webapi/lib/{bs,ocaml}/(238.ast+ 8.iast+ 2.ninja).These are compiled output of vendored ReScript libraries and were already
listed in
.gitignore(lines 56–61) — they were just committed beforethe ignore rules existed.
git rm --cacheduntracks them; files remain ondisk and
.gitignoreprevents re-adding.Zero source impact: no first-party code, no build wiring touched.
Not in this PR (rest of #33)
The actual ReScript → AffineScript port (~90 first-party
.res/.resifiles) is blocked: the AffineScript compiler/toolchain is not present
in the repo, so code cannot be ported yet. Tracked in #33 stages 2–4.
Test plan
git ls-files | grep -E 'gui/lib/rescript-[^/]+/lib/(bs|ocaml)/'returns nothingRefs #33
https://claude.ai/code/session_01LKw5BvbbxFUWi9YMogGJTL
Generated by Claude Code