You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
`eframe = "0.34"` (and the egui chain it pulls) raises MSRV above
1.85.0, which conflicts with the project's declared `rust-version =
"1.85.0"`. The MSRV CI job ran `cargo check --all-features` against
1.85, so any push silently passed (the job is currently red on main)
or would fail once toolchain caches refresh.
Move eframe into a new opt-in `gui` feature. The default and existing
optional features (`signing`, `http`) stay MSRV-clean; users who want
the native viewer build with `--features gui` on a newer toolchain.
Changes:
- Cargo.toml: `eframe = { ..., optional = true }`; add `gui = ["eframe"]`.
- src/report/mod.rs: cfg-gate `mod gui` and the `pub use ReportGui`.
- src/main.rs: cfg-gate the `Commands::Gui` clap variant and its match arm.
- .github/workflows/rust-ci.yml: MSRV `cargo check` now uses
`--features signing,http` (drops `--all-features` to exclude `gui`).
Verified locally:
* `cargo check` — OK (default)
* `cargo check --features signing,http` — OK (the new MSRV check command)
* `cargo check --features gui` — OK (opt-in build still works)
* `cargo clippy --all-features --all-targets -- -D warnings` — clean
* `cargo test --features signing,http --no-fail-fast` — all 17 suites OK
* `cargo fmt --check` — clean
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0 commit comments