You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Summary
`eframe = "0.34"` (and the `egui` chain it pulls) raises MSRV above
1.85.0, which conflicts with the project's declared `rust-version =
"1.85.0"` and breaks the MSRV CI job.
Move `eframe` into a new opt-in `gui` feature so default + non-GUI
optional builds stay MSRV-clean. Users who want the native viewer build
with `--features gui` on a newer toolchain.
### Changes (4 files, +12/-3)
| File | Change |
|------|--------|
| `Cargo.toml` | `eframe = { ..., optional = true }`; add `gui =
["eframe"]` feature |
| `src/report/mod.rs` | cfg-gate `pub mod gui` + `pub use
gui::ReportGui` |
| `src/main.rs:472` | cfg-gate the `Commands::Gui` clap variant |
| `src/main.rs:1703` | cfg-gate the `Commands::Gui { .. }` match arm |
| `.github/workflows/rust-ci.yml` | MSRV check: `cargo check --features
signing,http` (was `--all-features`) |
### Why `--features signing,http` not `--all-features`
The MSRV job should test what users actually consume on the declared
MSRV. `signing` (ed25519-dalek 2.1) and `http` (ureq 3.3) are both
1.85-compatible. The new `gui` feature explicitly raises MSRV — building
it on 1.85 will fail, which is correct behaviour.
## Test plan
- [x] `cargo check` — default build OK
- [x] `cargo check --features signing,http` — the new MSRV check command
OK
- [x] `cargo check --features gui` — opt-in build still works
- [x] `cargo clippy --all-features --all-targets -- -D warnings` — clean
- [x] `cargo test --features signing,http --no-fail-fast` — all 17
suites pass
- [x] `cargo fmt --check` — clean
- [x] Signed commit, MPL-2.0 headers untouched
## Follow-up
Future improvement: add a `cargo check --features gui` job pinned to a
recent stable Rust so the GUI path stays buildable. Out of scope for
this PR (single-concern unbreakage).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0 commit comments