Skip to content

fix(reconcile): --verify no longer crashes JSON-encoding its result #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
May 19, 2026
Merged

fix(reconcile): --verify no longer crashes JSON-encoding its result #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/mix/tasks/hypatia.reconcile.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ defmodule Mix.Tasks.Hypatia.Reconcile do

result =
if opts[:verify] do
ScorecardReconciler.verify(owner, repo)
# verify/2 returns {:ok, summary} | {:error, reason}; reconcile/3
# returns a bare map. Normalise verify to a bare map so the
# Jason.encode! below never receives a tuple (it cannot encode
# one — `mix hypatia.reconcile --verify` used to crash here).
case ScorecardReconciler.verify(owner, repo) do
{:ok, summary} -> summary
{:error, reason} -> %{repo: "#{owner}/#{repo}", verified: false, error: reason}
end
else
ScorecardReconciler.reconcile(owner, repo,
dry_run: !!opts[:dry_run],
Expand Down
Loading