fix: cross-module imports for stdlib (ADR-011) + module builtin seeding (#135) (#172)

The ruled ADR-011 model is explicit `use module::{...}`. io.affine
needs string.affine's split/join. Three coupled fixes:

1. resolve.ml: factor builtin seeding into `seed_builtins` and call it
   in `resolve_and_typecheck_module` — imported modules previously got
   a bare context, so resolving e.g. string.affine (pulled in by io's
   `use`) failed with UndefinedVariable "len".
2. resolve.ml: call `Typecheck.register_builtins` in the imported-module
   typecheck path (the manual check_decl fold skipped it, giving
   "Unbound variable: len" at the typecheck stage).
3. typecheck.ml: `register_builtins` was missing eprint/eprintln
   (resolver seeds them; typecheck did not).
Plus: `pub` on string.split/join; `use string::{ split, join };` in io.

Result: io.affine now passes resolution fully (ADR-011 cross-module
import works end to end). io's remaining typecheck failure is a
separate pre-existing register_builtins drift (file-I/O builtin family
+ read_line type), tracked separately. Full suite 233/233 green, zero
regression; stdlib 12/19 (unchanged count, io advanced resolve→tc).

Refs #128

Author: hyperpolymath

lib/resolve.ml

@@ -43,16 +43,14 @@ type context = {
 (* Helper for Result bind *)
 let ( let* ) = Result.bind
 
-(** Create a new resolution context *)
-let create_context () : context =
-  let ctx = {
-    symbols = Symbol.create ();
-    current_module = [];
-    imports = [];
-    references = [];
-  } in
-  (* Register built-in functions — must match the interpreter's create_initial_env *)
-  let def name = let _ = Symbol.define ctx.symbols name SKFunction Span.dummy Public in () in
+(** Seed the builtin functions/constructors into a symbol table.
+    Shared by [create_context] (top-level program) and
+    [resolve_and_typecheck_module] (imported modules) so that an imported
+    stdlib module — e.g. [string.affine] pulled in by [use string::{...}] —
+    resolves its own use of builtins like [len] instead of failing with
+    [UndefinedVariable]. Must match the interpreter's create_initial_env. *)
+let seed_builtins (symbols : Symbol.t) : unit =
+  let def name = let _ = Symbol.define symbols name SKFunction Span.dummy Public in () in
   (* Console I/O *)
   def "print"; def "println"; def "eprint"; def "eprintln";
   (* String / char builtins *)
@@ -88,9 +86,19 @@ let create_context () : context =
      gap. A user/prelude `type Option`/`type Result` decl cleanly shadows these
      (Hashtbl.replace in Symbol.define). Issue #122. *)
   let defc name =
-    let _ = Symbol.define ctx.symbols name SKConstructor Span.dummy Public in ()
+    let _ = Symbol.define symbols name SKConstructor Span.dummy Public in ()
   in
-  defc "Some"; defc "None"; defc "Ok"; defc "Err";
+  defc "Some"; defc "None"; defc "Ok"; defc "Err"
+
+(** Create a new resolution context, pre-seeded with builtins. *)
+let create_context () : context =
+  let ctx = {
+    symbols = Symbol.create ();
+    current_module = [];
+    imports = [];
+    references = [];
+  } in
+  seed_builtins ctx.symbols;
   ctx
 
 (** Record a use-site reference for a symbol (Phase C: find-references). *)
@@ -548,6 +556,7 @@ let resolve_and_typecheck_module (loaded_mod : Module_loader.loaded_module)
     : (Symbol.t * Typecheck.context) result =
   let prog = Module_loader.get_program loaded_mod in
   let symbols = Symbol.create () in
+  seed_builtins symbols;
   let mod_ctx = { symbols; current_module = []; imports = []; references = [] } in
 
   (* Pass 1: forward-declare every top-level name (#135 slice 11). *)
@@ -559,8 +568,12 @@ let resolve_and_typecheck_module (loaded_mod : Module_loader.loaded_module)
     | Ok () -> resolve_decl mod_ctx decl
   ) (Ok ()) prog.prog_decls in
 
-  (* Type-check all declarations *)
+  (* Type-check all declarations. Seed builtin schemes (len, arithmetic,
+     Some/None/…) exactly as Typecheck.check_program does for the top-level
+     program — the manual check_decl fold below otherwise leaves an imported
+     module's use of builtins as "Unbound variable". *)
   let type_ctx = Typecheck.create_context symbols in
+  Typecheck.register_builtins type_ctx;
   let type_result = List.fold_left (fun acc decl ->
     match acc with
     | Error e -> Error e

lib/typecheck.ml

@@ -1194,6 +1194,8 @@ let register_builtins (ctx : context) : unit =
   let float_binop = TArrow (ty_float, QOmega, TArrow (ty_float, QOmega, ty_float, EPure), EPure) in
   bind_var ctx "print" (TArrow (ty_string, QOmega, ty_unit, ESingleton "IO"));
   bind_var ctx "println" (TArrow (ty_string, QOmega, ty_unit, ESingleton "IO"));
+  bind_var ctx "eprint" (TArrow (ty_string, QOmega, ty_unit, ESingleton "IO"));
+  bind_var ctx "eprintln" (TArrow (ty_string, QOmega, ty_unit, ESingleton "IO"));
   bind_var ctx "read_line" (TArrow (ty_unit, QOmega, ty_string, ESingleton "IO"));
   bind_var ctx "int_to_string" (TArrow (ty_int, QOmega, ty_string, EPure));
   bind_var ctx "int" (TArrow (ty_float, QOmega, ty_int, EPure));

stdlib/io.affine

@@ -20,6 +20,9 @@
 //   show(value)             -> String
 //   time_now()              -> Float              (CPU time in seconds)
 
+// Cross-module import (ADR-011: explicit `use module::{...}`)
+use string::{ split, join };
+
 // ============================================================================
 // Console Output
 // ============================================================================

stdlib/string.affine

@@ -116,7 +116,7 @@ fn repeat(s: String, n: Int) -> String {
 }
 
 /// Split string by a delimiter
-fn split(s: String, delimiter: String) -> [String] {
+pub fn split(s: String, delimiter: String) -> [String] {
   let slen = len(s);
   let dlen = len(delimiter);
 
@@ -151,7 +151,7 @@ fn split(s: String, delimiter: String) -> [String] {
 }
 
 /// Join an array of strings with a separator
-fn join(arr: [String], separator: String) -> String {
+pub fn join(arr: [String], separator: String) -> String {
   if len(arr) == 0 {
     return "";
   }