fix(ci): three foundational unblocks for the main-branch baseline (PR-queue clear)

Every open PR (#357–#360) is MERGEABLE/UNSTABLE because main itself has three
independent baselines red. Same red shows up on every new PR. Fix each at
source so it stops blocking the whole queue.

## 1. `bench/dune` — `Unknown field "alias"` (build + lint)

`(test ...)` in dune 3.x does not accept `(alias <name>)` as an inline field.
The pattern that works under dune 3.14:

  (executable ...)         ; build the bench runner without auto-@runtest
  (rule (alias bench)      ; only run when explicitly targeted via @bench
        (action (run ...)))

Preserves the visibility-only contract (`just bench` / `dune runtest @bench`
still work; normal `dune runtest` no longer pulls bench in).

## 2. Anti-pattern false-positive on `.res` test fixture (governance)

`tools/res-to-affine/test/fixtures/sample.res` is the input corpus for the
`.res → .affine` migration tool (#57). The estate ban on `.res` files
correctly flags it, but the file is fixture-by-construction. The governance
bundle already supports an in-file pragma read from the first 8 lines —
add `// hypatia:ignore cicd_rules/banned_language_file` to the fixture
header so the exemption travels with the file rather than living in a
side-channel `.hypatia-ignore` list.

## 3. npm 404 on `@hyperpolymath/affine-vscode` (vscode-smoke)

The adapter package is gated on owner action #104 (org create + NPM_TOKEN +
`affine-vscode-v0.1.0` tag push) and has not landed. Until then `npm install`
404s and the smoke harness can't even load the extension.

Two layers of fix:

- `editors/vscode/package.json`: move `@hyperpolymath/affine-vscode` from
  `dependencies` → `optionalDependencies` so `npm install` tolerates the
  404 instead of erroring out. When the package eventually publishes, real
  installs pick it up automatically.

- `lib/codegen_node.ml`: the `--vscode-extension` codegen was emitting an
  unconditional `const _makeVscodeBindings = require("...")` at top level.
  Replace with a defensive `try { } catch (_e) { if code !== MODULE_NOT_FOUND
  throw }` wrapper plus a guarded `extraImports` that returns `{}` when the
  adapter is absent. Other require errors (syntax, transitive failure) are
  still rethrown so real bugs aren't masked. Same patch applied to the
  already-committed `editors/vscode/out/extension.cjs` so today's CI sees
  the fix without a compiler rebuild round-trip.

This is the upstream fix — any future extension compiled with
`--vscode-extension` inherits graceful degradation. activate() / deactivate()
resolve cleanly when the adapter is missing; the in-editor smoke harness
(#139) verifies activation + command registration + restartLsp cycling,
which do not require the binding adapter.

Refs #104 (adapter publish remains owner-blocked but no longer load-bearing
for CI); Refs #57 (migration assistant); Refs #139 (vscode smoke harness).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

bench/dune

@@ -20,8 +20,17 @@
 ;   bench/bench_typecheck.ml   typecheck + quantity sweep
 ;   bench/bench_codegen.ml     wasm-codegen sweep
 
-(test
+; `(test ...)` would auto-register bench_main under @runtest, defeating the
+; visibility-only contract. Use `(executable ...)` + a dedicated `(rule
+; (alias bench) ...)` so the bench is only invoked when explicitly targeted
+; (`dune runtest @bench` / `just bench`). The previous `(alias bench)` field
+; on `(test ...)` was rejected by dune 3.x as Unknown field.
+
+(executable
  (name bench_main)
  (libraries affinescript alcotest unix)
- (modules bench_main bench_fixtures bench_lex bench_parse bench_typecheck bench_codegen)
- (alias bench))
+ (modules bench_main bench_fixtures bench_lex bench_parse bench_typecheck bench_codegen))
+
+(rule
+ (alias bench)
+ (action (run %{exe:bench_main.exe})))

editors/vscode/out/extension.cjs

@@ -98,8 +98,21 @@ exports._freeHandle = _freeHandle;
 // Inserted by --vscode-extension (issue #105): auto-generated glue so this
 // file is directly loadable as a VS Code extension's `main`. Replaces the
 // previously hand-written index.cjs + vendored adapter boilerplate.
-const _makeVscodeBindings = require("@hyperpolymath/affine-vscode");
+//
+// Defensive load (issue #104): the adapter package may not yet be on npm
+// when this .cjs is bundled into a smoke harness or distributed before the
+// `affine-vscode-v*` publish-tag lands. Treat MODULE_NOT_FOUND as a soft
+// failure — extraImports degrades to empty so activate()/deactivate() still
+// resolve. Any other require error (syntax, transitive failure) is rethrown
+// so real bugs are not masked.
+let _makeVscodeBindings = null;
+try {
+  _makeVscodeBindings = require("@hyperpolymath/affine-vscode");
+} catch (_e) {
+  if (_e && _e.code !== "MODULE_NOT_FOUND") throw _e;
+}
 exports.extraImports = function() {
+  if (typeof _makeVscodeBindings !== "function") return {};
   return _makeVscodeBindings(
     require("vscode"),
     require("vscode-languageclient/node"),

editors/vscode/package.json

@@ -150,7 +150,9 @@
     "vsce": "^2.15.0"
   },
   "dependencies": {
-    "@hyperpolymath/affine-vscode": "^0.1.0",
     "vscode-languageclient": "^9.0.0"
+  },
+  "optionalDependencies": {
+    "@hyperpolymath/affine-vscode": "^0.1.0"
   }
 }

lib/codegen_node.ml

@@ -132,8 +132,21 @@ let vscode_extension_wiring ~(adapter : string) ~(no_lc : bool) : string =
 // Inserted by --vscode-extension (issue #105): auto-generated glue so this
 // file is directly loadable as a VS Code extension's `main`. Replaces the
 // previously hand-written index.cjs + vendored adapter boilerplate.
-const _makeVscodeBindings = require("%s");
+//
+// Defensive load (issue #104): the adapter package may not yet be on npm
+// when this .cjs is bundled into a smoke harness or distributed before the
+// `affine-vscode-v*` publish-tag lands. Treat MODULE_NOT_FOUND as a soft
+// failure — extraImports degrades to empty so activate()/deactivate() still
+// resolve. Any other require error (syntax, transitive failure) is rethrown
+// so real bugs are not masked.
+let _makeVscodeBindings = null;
+try {
+  _makeVscodeBindings = require("%s");
+} catch (_e) {
+  if (_e && _e.code !== "MODULE_NOT_FOUND") throw _e;
+}
 exports.extraImports = function() {
+  if (typeof _makeVscodeBindings !== "function") return {};
   return _makeVscodeBindings(
     require("vscode"),
     %s,

tools/res-to-affine/test/fixtures/sample.res

@@ -1,6 +1,11 @@
 // SPDX-License-Identifier: MIT
+// hypatia:ignore cicd_rules/banned_language_file
 // Synthetic fixture exercising every Phase-1 anti-pattern. Not a real
 // ReScript program; the scanner is line-based so it doesn't care.
+// The .res extension is intentional — this fixture is the input to the
+// `.res → .affine` migration tool (issue #57); exempted from the banned-
+// language policy via the inline pragma above (governance bundle reads
+// the first 8 lines for `hypatia:ignore <rule>`).
 
 open Types