Join Peer By Snapshot

[Tubar2]

Is your proposal related to a problem?

I have recently implemented the methods for creating, canceling and listing snapshot requests from peers, however there is no support for joining a peer using this snapshot.

Describe the solution you'd like

I would like to implement a JoinPeerBySnapshot method that receives a snapshot and joins a given peer to the channel, using it.

Scenario:
Given I have a snapshot
When I call `JoinPeerBySnapshot`
Then the peer joins the channel

Additional context

It would be interesting to test this feature using the e2e test. Since the test-network uses the fabric-samples test-network I'm not sure how to proceed.

I thought it could be something along the lines of:

1. Start test-network with a second peer form org1:peer1.org1.example.com
2. Create Channel using the e2e test
3. Join peer0.org1 to mychannel
4. Create Snapshot with peer0.org1
5. Join peer1.org1 using Snapshot

The rest of the test would be the same

[bestbeforetoday]

Thank you for raising the issue. This is great enhancement. The existing end-to-end test has a code path where the test-network is brought up but the scripts from the fabric-samples repository are not used to create the channel. Instead, the admin SDK is used to create the channel and join peers.

fabric-admin-sdk/test/e2e_test.go

Lines 229 to 235 in d33af1b

	//join peer1
	err = channel.JoinChannel(specCtx, peer1Connection, org1MSP, block)
	Expect(err).NotTo(HaveOccurred())
	//join peer2
	err = channel.JoinChannel(specCtx, peer2Connection, org2MSP, block)
	Expect(err).NotTo(HaveOccurred())

I wonder if you could adapt this approach to test a new JoinPeerBySnapshot function by joining a peer with that instead of with channel.JoinChannel? Since the end-to-end test is already very busy, it might be worth copying just the relevant portions to a new test that exercises JoinPeerBySnapshot rather that extended the existing end-to-end test even further.