Expose configurable frontend pipe slot_num#710
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an optional compile-time integer attribute slot_num to the frontend pipe initialization operations (pto.aic_initialize_pipe and pto.aiv_initialize_pipe). This attribute controls the GM ring FIFO depth, which previously defaulted to fixed values of 8 or 4 depending on the communication direction (dir_mask). The changes include updating the ODS definitions, adding parsing and printing logic, enhancing verification rules to ensure slot_num is positive and local_slot_num does not exceed it, and updating lowering passes to propagate this attribute. Documentation and comprehensive LIT tests have also been added to verify correct behavior and error handling. I have no feedback to provide as there are no review comments.
Codex Review该评论由 review 机器人自动更新。
SummaryFound public contract mismatches in the updated configurable Findings
Section 4.4 still states that
The updated manual says |
Summary: add optional slot_num to frontend aic/aiv initialize_pipe ops, forward it during lowering, relax internal pipe slot_num verification to positive values, and keep local_slot_num bounded by slot_num. Tests: ninja -C build-main-wsl ptoas; llvm-lit related frontend/internal slot_num tests; llvm-lit existing tpush/tpop regression tests. Fixes #709