fix: Address Copilot review suggestions

- Pin Node.js to 20.20.0 (meets posthog-node engine requirement)
- Fix Slack RTM -> Socket Mode in AI generator prompt
- Remove duplicate playlist queueing (was queuing twice)
- Fix heredoc variable expansion in workflow
- Comment out unused utils import
- Add githubToken to setconfig with sensitive masking
- Improve featurerequest error message with setup instructions

Author: htilly

.github/agent/generate-implementation.mjs

@@ -112,7 +112,7 @@ Your task is to analyze the feature request and generate a concrete implementati
 
 Project context:
 - Node.js application
-- Uses Slack RTM API and Discord.js
+- Uses Slack Socket Mode / Events API (via @slack/socket-mode) and Discord.js
 - Controls Sonos speakers
 - Has voting system for democratic music control
 - Uses AI for natural language commands

.github/workflows/feature-request-enhance.yml

@@ -88,7 +88,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: '20.20.0'
           cache: npm
 
       - name: Install dependencies
@@ -157,7 +157,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: '20.20.0'
           cache: npm
 
       - name: Install dependencies
@@ -267,7 +267,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: '20.20.0'
           cache: npm
 
       - name: Install agent dependencies
@@ -312,7 +312,7 @@ jobs:
             git add "$IMPL_FILE"
 
             # Create commit with heredoc to handle multiline
-            git commit -m "$(cat <<'EOF'
+            git commit -m "$(cat <<EOF
           Add implementation plan for issue #$ISSUE_NUMBER
 
           This is an AI-generated implementation plan created by Claude.

index.js

@@ -36,7 +36,7 @@ const googleTTS = require('@sefinek/google-tts-api');
 const config = require('nconf');
 const winston = require('winston');
 const Spotify = require('./lib/spotify');
-const utils = require('./lib/utils');
+// const utils = require('./lib/utils'); // Currently unused
 const process = require('process');
 const parseString = require('xml2js').parseString;
 const http = require('http');
@@ -4748,7 +4748,17 @@ async function _featurerequest(input, channel, userName) {
   const githubToken = config.get('githubToken');
   if (!githubToken) {
     logger.warn('[FEATUREREQUEST] githubToken not configured');
-    _slackMessage('❌ Feature request functionality is not configured. Please set `githubToken` in the config to enable this feature.', channel);
+    _slackMessage(
+      '❌ *Feature request not configured*\n\n' +
+      'To enable this feature, you need a GitHub Personal Access Token:\n\n' +
+      '1. Go to: https://github.com/settings/tokens\n' +
+      '2. Click *"Generate new token (classic)"*\n' +
+      '3. Select scope: `repo` (or `public_repo` for public repos only)\n' +
+      '4. Set the token via admin command:\n' +
+      '   `setconfig githubToken ghp_xxxxxxxxxxxx`\n\n' +
+      '📖 More info: https://github.com/htilly/SlackONOS#configuration',
+      channel
+    );
     return;
   }
 
@@ -4930,7 +4940,8 @@ async function _setconfig(input, channel, userName) {
     soundcraftIp: { type: 'string', minLen: 0, maxLen: 50 },
     crossfadeEnabled: { type: 'boolean' },
     slackAlwaysThread: { type: 'boolean' },
-    logLevel: { type: 'string', minLen: 4, maxLen: 5, allowed: ['error', 'warn', 'info', 'debug'] }
+    logLevel: { type: 'string', minLen: 4, maxLen: 5, allowed: ['error', 'warn', 'info', 'debug'] },
+    githubToken: { type: 'string', minLen: 4, maxLen: 100, sensitive: true }
   };
 
   // Make config key case-insensitive
@@ -5056,7 +5067,13 @@ async function _setconfig(input, channel, userName) {
         _slackMessage(`⚠️ Updated \`${actualKey}\` in memory, but failed to save to disk!`, channel);
         return;
       }
-      _slackMessage(`✅ Successfully updated \`${actualKey}\` and saved to config.\nOld: \`${oldValue.slice(0, 80)}${oldValue.length > 80 ? '…' : ''}\`\nNew: \`${newValue.slice(0, 80)}${newValue.length > 80 ? '…' : ''}\``, channel);
+      // Mask sensitive values (like tokens)
+      if (configDef.sensitive) {
+        const maskedValue = newValue.slice(0, 4) + '****' + newValue.slice(-4);
+        _slackMessage(`✅ Successfully updated \`${actualKey}\` and saved to config.\nNew: \`${maskedValue}\` (${newValue.length} chars)`, channel);
+      } else {
+        _slackMessage(`✅ Successfully updated \`${actualKey}\` and saved to config.\nOld: \`${oldValue.slice(0, 80)}${oldValue.length > 80 ? '…' : ''}\`\nNew: \`${newValue.slice(0, 80)}${newValue.length > 80 ? '…' : ''}\``, channel);
+      }
     });
   } else if (configDef.type === 'boolean') {
     const lowerValue = value.toLowerCase();

lib/add-handlers.js

@@ -579,28 +579,10 @@ async function addplaylist(input, channel, userName) {
     logger.info(`Sending playlist confirmation message: ${text}`);
     sendMessage(text, channel, { trackName: result.name });
 
-    // Queue tracks in background (don't block user response)
+    // Note: Queueing is already done synchronously above (lines 532-545)
+    // This background task only handles playback if needed
     (async () => {
       try {
-        if (blacklistedTracks.length > 0) {
-          const allowedTracks = playlistTracks.filter(track =>
-            !isTrackBlacklisted(track.name, track.artist)
-          );
-
-          const queuePromises = allowedTracks.map(track =>
-            sonos.queue(track.uri).catch(err => {
-              logger.warn(`Could not queue track ${track.name}: ${err.message}`);
-              return null;
-            })
-          );
-
-          await Promise.allSettled(queuePromises);
-          logger.info(`Added ${allowedTracks.length} tracks from playlist (filtered ${blacklistedTracks.length})`);
-        } else {
-          await sonos.queue(result.uri);
-          logger.info('Added playlist: ' + result.name);
-        }
-
         if (isStopped) {
           await new Promise(resolve => setTimeout(resolve, 300));
           await sonos.play();