Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/classes/TestResult.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ export default class TestResult extends BubblingEventTarget {
}
}
catch (e) {
// Duck-type assertion errors (Node assert, Chai, etc.) — use their actual/expected for diffs
if ("actual" in e) {
this.actual = e.actual;
this.test.expect = e.expected;
}
this.error = e;
}
}
Expand Down Expand Up @@ -374,7 +379,8 @@ export default class TestResult extends BubblingEventTarget {
}

if (!ret.pass) {
if (this.error) {
// Assertion errors have `.actual` — show diff instead of raw error dump
if (this.error && !("actual" in this.error)) {
ret.details.push(`Got error ${this.error}
${this.error.stack}`);
}
Expand Down
15 changes: 15 additions & 0 deletions tests/errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -229,5 +229,20 @@ export default {
},
expect: true,
},
{
name: "AssertionError treated as failure (issue #114)",
skip: typeof globalThis.process === "undefined",
async run () {
let { strict: assert } = await import("node:assert");
let result = await runTest({
run () {
assert.equal("hello".toUpperCase(), "hello");
},
expect: "HELLO",
});
return { actual: result.actual, expected: result.test.expect, pass: result.pass };
},
expect: { actual: "HELLO", expected: "hello", pass: false },
},
],
};