Handle AssertionError as failure, not error#150
Open
DmitrySharabin wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for h-test ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DmitrySharabin
force-pushed
the
handle-assertion-error
branch
2 times, most recently
from
609dd1b to
2274d7b
Compare
DmitrySharabin
changed the title
DmitrySharabin
changed the title
DmitrySharabin
force-pushed
the
handle-assertion-error
branch
3 times, most recently
from
9e9a326 to
86da6fa
Compare
Duck-type errors with an `actual` property (Node assert, Chai, etc.) and extract the value for normal diff output instead of dumping a raw error + stack trace. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DmitrySharabin
force-pushed
the
handle-assertion-error
branch
from
86da6fa to
f62d3e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert, Chai, etc.) as test failures with proper diffs instead of raw error dumps"actual" in eto support multiple assertion librariesactualandexpectedfrom the error for diff outputcheck()resultCloses #114
Test plan
tests/errors.jsverifiesactualandexpectedare extracted from the assertion error and the test fails🤖 Generated with Claude Code