Summary
Follow-up from #530 / PR #550. The initial admin error-sanitization pass fixed handlers.go, bot_config_handlers.go, and apikey_handlers.go. internal/admin/cron_handlers.go still has 5 sites that expose internal error strings in HTTP responses.
Affected locations
| Line |
Current |
Should be |
| ~33 |
respondError(w, http.StatusInternalServerError, err.Error()) |
log + "internal error" |
| ~51 |
respondError(w, http.StatusNotFound, err.Error()) |
log + "not found" |
| ~113 |
respondError(w, http.StatusInternalServerError, err.Error()) |
log + "internal error" |
| ~131 |
respondError(w, http.StatusNotFound, err.Error()) |
log + "not found" |
| ~150 |
respondError(w, http.StatusInternalServerError, err.Error()) |
log + "internal error" |
Scope
Same pattern as the #530 fix: server-side log.Error + generic client-facing message. No behavior change beyond error message content.
Summary
Follow-up from #530 / PR #550. The initial admin error-sanitization pass fixed
handlers.go,bot_config_handlers.go, andapikey_handlers.go.internal/admin/cron_handlers.gostill has 5 sites that expose internal error strings in HTTP responses.Affected locations
respondError(w, http.StatusInternalServerError, err.Error())"internal error"respondError(w, http.StatusNotFound, err.Error())"not found"respondError(w, http.StatusInternalServerError, err.Error())"internal error"respondError(w, http.StatusNotFound, err.Error())"not found"respondError(w, http.StatusInternalServerError, err.Error())"internal error"Scope
Same pattern as the #530 fix: server-side
log.Error+ generic client-facing message. No behavior change beyond error message content.