Skip to content

parse_asnames() fails since stringi 1.8.1 (fallback_encoding removed) #1

@dfirr

Description

@dfirr

Hi, thanks for astools!

parse_asnames() fails with stringi >= 1.8.1 because fallback_encoding was removed, so the call to stri_read_lines(..., fallback_encoding = "UTF-8") now errors.

Proposed fix (UTF-8 input assumed):

  • use stringi::stri_read_lines(as_fil, encoding = "UTF-8")

I've implemented this change and added a minimal test for parse_asnames() in my fork/branch. Happy to open a PR here if you'd like.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions