ci: use docker hub images directly

Author: fredleger

.github/workflows/__shared-ci.yml

@@ -71,6 +71,35 @@ jobs:
           file: coverage.lcov
           allow-empty: true
 
+  docker-build-images:
+    name: "Docker: Build Images"
+    needs: [golangci-lint, go-test, go-coverage, chart-testing]
+    uses: hoverkraft-tech/ci-github-container/.github/workflows/docker-build-images.yml@0.15.0
+    permissions:
+      actions: write
+      contents: read
+      id-token: write
+      issues: read
+      packages: write
+      pull-requests: read
+    secrets:
+      oci-registry-password: ${{ secrets.DOCKERHUB_REGISTRY_PASSWORD }}
+    with:
+      runs-on: '["self-hosted"]'
+      oci-registry: "docker.io"
+      oci-registry-username: ${{ vars.DOCKERHUB_REGISTRY_USERNAME }}
+      images: |
+        [{
+          "name": "http-header-authenticator",
+          "repository": "webofmars",
+          "tag": "${{ inputs.tag }}",
+          "dockerfile": "./Dockerfile",
+          "platforms": [
+            "linux/amd64",
+            "linux/arm64"
+          ]
+        }]
+
   chart-testing:
     name: "Helm: Chart Testing"
     runs-on: self-hosted
@@ -112,30 +141,3 @@ jobs:
       - name: Run chart-testing (install)
         if: steps.list-changed.outputs.changed == 'true'
         run: ct install --target-branch ${{ github.event.repository.default_branch }}
-
-  docker-build-images:
-    name: "Docker: Build Images"
-    needs: [golangci-lint, go-test, go-coverage, chart-testing]
-    uses: hoverkraft-tech/ci-github-container/.github/workflows/docker-build-images.yml@0.15.0
-    permissions:
-      actions: write
-      contents: read
-      id-token: write
-      issues: read
-      packages: write
-      pull-requests: read
-    secrets:
-      oci-registry-password: ${{ secrets.GITHUB_TOKEN }}
-    with:
-      runs-on: '["self-hosted"]'
-      oci-registry: "ghcr.io"
-      images: |
-        [{
-          "name": "app",
-          "tag": "${{ inputs.tag }}",
-          "dockerfile": "./Dockerfile",
-          "platforms": [
-            "linux/amd64",
-            "linux/arm64"
-          ]
-        }]

.github/workflows/pull-request-ci.yml

@@ -24,6 +24,7 @@ jobs:
     name: Continuous Integration
     uses: ./.github/workflows/__shared-ci.yml
     permissions:
+      actions: write
       contents: read
       id-token: write
       issues: read

.github/workflows/release.yml

@@ -43,28 +43,6 @@ jobs:
           publish: true
           disable-autolabeler: true
 
-      - uses: docker/login-action@v3
-        with:
-          registry: "ghcr.io"
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - uses: docker/login-action@v3
-        with:
-          registry: "docker.io"
-          username: ${{ secrets.DOCKERHUB_REGISTRY_USER     }}
-          password: ${{ secrets.DOCKERHUB_REGISTRY_PASSWORD }}
-
-      - name: Push built images to Docker.io
-        run: |
-          APP_IMAGE="${{ fromJson(needs.ci.outputs.built-images).app.images[0] }}"
-          docker pull "$APP_IMAGE"
-          APP_TAG="${{ steps.update_release_draft.outputs.tag_name }}"
-          APP_REGISTRY_PATH="docker.io/webofmars"
-          APP_DOCKERIO_IMAGE="${APP_REGISTRY_PATH}/http-header-authenticator:$APP_TAG"
-          docker tag "$APP_IMAGE" "$APP_DOCKERIO_IMAGE"
-          docker push "$APP_DOCKERIO_IMAGE"
-
   helm-push:
     name: "Helm: push chart to harbor registry"
     needs: ci

.tool-versions

@@ -1,2 +1 @@
-skaffold 2.8.0
 helm 3.12.1