From ff10caa16162a856e2e3aa0f7829db6223d626f9 Mon Sep 17 00:00:00 2001 From: Martijn Hoekstra Date: Thu, 23 Jan 2020 12:56:45 +0100 Subject: [PATCH 1/2] Depend on nuget packages instead of submodule --- Heroes.ReplayParser | 1 - Hotsapi.Uploader.Common/Analyzer.cs | 5 +- .../Hotsapi.Uploader.Common.csproj | 5 +- Hotsapi.Uploader.sln | 122 ++++++++---------- 4 files changed, 56 insertions(+), 77 deletions(-) delete mode 160000 Heroes.ReplayParser diff --git a/Heroes.ReplayParser b/Heroes.ReplayParser deleted file mode 160000 index abf87de..0000000 --- a/Heroes.ReplayParser +++ /dev/null @@ -1 +0,0 @@ -Subproject commit abf87de8344f6b9beaecd0173592b9d8da78fe17 diff --git a/Hotsapi.Uploader.Common/Analyzer.cs b/Hotsapi.Uploader.Common/Analyzer.cs index 9dd5eb3..b6c463d 100644 --- a/Hotsapi.Uploader.Common/Analyzer.cs +++ b/Hotsapi.Uploader.Common/Analyzer.cs @@ -22,7 +22,10 @@ public class Analyzer : IAnalyzer public Replay Analyze(ReplayFile file) { try { - var result = DataParser.ParseReplay(file.Filename, false, false, false, true); + var parseOptions = new ParseOptions() { + AllowPTR = true + }; + var result = DataParser.ParseReplay(file.Filename, false, parseOptions); var replay = result.Item2; var parseResult = result.Item1; var status = GetPreStatus(replay, parseResult); diff --git a/Hotsapi.Uploader.Common/Hotsapi.Uploader.Common.csproj b/Hotsapi.Uploader.Common/Hotsapi.Uploader.Common.csproj index d412fbc..f4cf8e7 100644 --- a/Hotsapi.Uploader.Common/Hotsapi.Uploader.Common.csproj +++ b/Hotsapi.Uploader.Common/Hotsapi.Uploader.Common.csproj @@ -6,15 +6,12 @@ + - - - - diff --git a/Hotsapi.Uploader.sln b/Hotsapi.Uploader.sln index 22a4c3f..045a5fc 100644 --- a/Hotsapi.Uploader.sln +++ b/Hotsapi.Uploader.sln @@ -1,71 +1,51 @@ - -Microsoft Visual Studio Solution File, Format Version 12.00 -# Visual Studio Version 16 -VisualStudioVersion = 16.0.29519.87 -MinimumVisualStudioVersion = 10.0.40219.1 -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common", "Hotsapi.Uploader.Common\Hotsapi.Uploader.Common.csproj", "{DC695BCC-4403-4B20-B4F5-EB80683E5967}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Windows", "Hotsapi.Uploader.Windows\Hotsapi.Uploader.Windows.csproj", "{F774F86B-410F-410D-9719-ADF892D315D5}" -EndProject -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MpqTool.netstandard", "Heroes.ReplayParser\MpqTool\MpqTool.netstandard.csproj", "{401F4637-5826-4DDA-A666-A3B4D1994330}" -EndProject -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Heroes.ReplayParser.netstandard", "Heroes.ReplayParser\Heroes.ReplayParser\Heroes.ReplayParser.netstandard.csproj", "{7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Common.Test", "Hotsapi.Uploader.Common.Test\Hotsapi.Uploader.Common.Test.csproj", "{F0AF2897-857E-462E-86E0-2812624E2F78}" -EndProject -Global - GlobalSection(SolutionConfigurationPlatforms) = preSolution - Debug|Any CPU = Debug|Any CPU - Installer|Any CPU = Installer|Any CPU - Release|Any CPU = Release|Any CPU - Zip|Any CPU = Zip|Any CPU - EndGlobalSection - GlobalSection(ProjectConfigurationPlatforms) = postSolution - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.Build.0 = Debug|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.ActiveCfg = Release|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.Build.0 = Release|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.ActiveCfg = Release|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.Build.0 = Release|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.ActiveCfg = Release|Any CPU - {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.Build.0 = Release|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.Build.0 = Debug|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.ActiveCfg = Installer|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.Build.0 = Installer|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.ActiveCfg = Release|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.Build.0 = Release|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.ActiveCfg = Zip|Any CPU - {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.Build.0 = Zip|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Debug|Any CPU.Build.0 = Debug|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Installer|Any CPU.ActiveCfg = Release|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Installer|Any CPU.Build.0 = Release|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Release|Any CPU.ActiveCfg = Release|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Release|Any CPU.Build.0 = Release|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Zip|Any CPU.ActiveCfg = Release|Any CPU - {401F4637-5826-4DDA-A666-A3B4D1994330}.Zip|Any CPU.Build.0 = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Debug|Any CPU.Build.0 = Debug|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Installer|Any CPU.ActiveCfg = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Installer|Any CPU.Build.0 = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Release|Any CPU.ActiveCfg = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Release|Any CPU.Build.0 = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Zip|Any CPU.ActiveCfg = Release|Any CPU - {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Zip|Any CPU.Build.0 = Release|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.Build.0 = Debug|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.ActiveCfg = Debug|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.Build.0 = Debug|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.ActiveCfg = Release|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.Build.0 = Release|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.ActiveCfg = Debug|Any CPU - {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.Build.0 = Debug|Any CPU - EndGlobalSection - GlobalSection(SolutionProperties) = preSolution - HideSolutionNode = FALSE - EndGlobalSection - GlobalSection(ExtensibilityGlobals) = postSolution - SolutionGuid = {24555457-A9E2-4C94-B0E4-1BC34F4C042B} - EndGlobalSection -EndGlobal + +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 16 +VisualStudioVersion = 16.0.29519.87 +MinimumVisualStudioVersion = 10.0.40219.1 +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common", "Hotsapi.Uploader.Common\Hotsapi.Uploader.Common.csproj", "{DC695BCC-4403-4B20-B4F5-EB80683E5967}" +EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Windows", "Hotsapi.Uploader.Windows\Hotsapi.Uploader.Windows.csproj", "{F774F86B-410F-410D-9719-ADF892D315D5}" +EndProject +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common.Test", "Hotsapi.Uploader.Common.Test\Hotsapi.Uploader.Common.Test.csproj", "{F0AF2897-857E-462E-86E0-2812624E2F78}" +EndProject +Global + GlobalSection(SolutionConfigurationPlatforms) = preSolution + Debug|Any CPU = Debug|Any CPU + Installer|Any CPU = Installer|Any CPU + Release|Any CPU = Release|Any CPU + Zip|Any CPU = Zip|Any CPU + EndGlobalSection + GlobalSection(ProjectConfigurationPlatforms) = postSolution + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.Build.0 = Debug|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.ActiveCfg = Release|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.Build.0 = Release|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.ActiveCfg = Release|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.Build.0 = Release|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.ActiveCfg = Release|Any CPU + {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.Build.0 = Release|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.Build.0 = Debug|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.ActiveCfg = Installer|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.Build.0 = Installer|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.ActiveCfg = Release|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.Build.0 = Release|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.ActiveCfg = Zip|Any CPU + {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.Build.0 = Zip|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.Build.0 = Debug|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.ActiveCfg = Debug|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.Build.0 = Debug|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.ActiveCfg = Release|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.Build.0 = Release|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.ActiveCfg = Debug|Any CPU + {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.Build.0 = Debug|Any CPU + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE + EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {24555457-A9E2-4C94-B0E4-1BC34F4C042B} + EndGlobalSection +EndGlobal From 5d7ebc667396d74f07b7460b7284914c9e01f62a Mon Sep 17 00:00:00 2001 From: Martijn Hoekstra Date: Fri, 24 Jan 2020 09:53:01 +0100 Subject: [PATCH 2/2] consolidate sharpcompress version --- Hotsapi.Uploader.Common/Analyzer.cs | 7 +- .../Hotsapi.Uploader.Windows.csproj | 456 +++++++++--------- 2 files changed, 230 insertions(+), 233 deletions(-) diff --git a/Hotsapi.Uploader.Common/Analyzer.cs b/Hotsapi.Uploader.Common/Analyzer.cs index b6c463d..09470fc 100644 --- a/Hotsapi.Uploader.Common/Analyzer.cs +++ b/Hotsapi.Uploader.Common/Analyzer.cs @@ -21,11 +21,8 @@ public class Analyzer : IAnalyzer /// Replay file public Replay Analyze(ReplayFile file) { - try { - var parseOptions = new ParseOptions() { - AllowPTR = true - }; - var result = DataParser.ParseReplay(file.Filename, false, parseOptions); + try { + var result = DataParser.ParseReplay(file.Filename, false, ParseOptions.MinimalParsing); var replay = result.Item2; var parseResult = result.Item1; var status = GetPreStatus(replay, parseResult); diff --git a/Hotsapi.Uploader.Windows/Hotsapi.Uploader.Windows.csproj b/Hotsapi.Uploader.Windows/Hotsapi.Uploader.Windows.csproj index 23e0e21..58edd8b 100644 --- a/Hotsapi.Uploader.Windows/Hotsapi.Uploader.Windows.csproj +++ b/Hotsapi.Uploader.Windows/Hotsapi.Uploader.Windows.csproj @@ -1,229 +1,229 @@ - - - - - Debug - AnyCPU - {F774F86B-410F-410D-9719-ADF892D315D5} - WinExe - Hotsapi.Uploader.Windows - Hotsapi.Uploader - v4.6.2 - 512 - {60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} - 4 - true - - - - AnyCPU - true - full - false - bin\Debug\ - TRACE;DEBUG;NOSQUIRREL - prompt - 4 - - - AnyCPU - pdbonly - true - bin\Release\ - TRACE;NOSQUIRREL - prompt - 4 - - - Resources\uploader_icon_light.ico - - - bin\Zip\ - TRACE;NOSQUIRREL - true - pdbonly - AnyCPU - prompt - MinimumRecommendedRules.ruleset - true - - - bin\Installer\ - TRACE - true - pdbonly - AnyCPU - prompt - MinimumRecommendedRules.ruleset - true - - - - - - 1.5.0.235 - - - - - - - - - - - - - - - - - - - - - - - - - 4.0 - - - - - - - - MSBuild:Compile - Designer - - - - SettingsWindow.xaml - - - - - - - - - - MSBuild:Compile - Designer - - - App.xaml - Code - - - MainWindow.xaml - Code - - - Designer - MSBuild:Compile - - - Designer - MSBuild:Compile - - - Designer - MSBuild:Compile - - - MSBuild:Compile - Designer - - - MSBuild:Compile - Designer - - - MSBuild:Compile - Designer - - - MSBuild:Compile - Designer - - - - - Code - - - True - True - Resources.resx - - - True - Settings.settings - True - - - - - - - ResXFileCodeGenerator - Resources.Designer.cs - - - Always - Designer - - - Designer - - - Designer - - - PublicSettingsSingleFileGenerator - Settings.Designer.cs - - - - - Designer - - - - - {DC695BCC-4403-4B20-B4F5-EB80683E5967} - Hotsapi.Uploader.Common - - - - - - - False - - - False - - - - - - - - - - - - - - - - - - - - - + + + + + Debug + AnyCPU + {F774F86B-410F-410D-9719-ADF892D315D5} + WinExe + Hotsapi.Uploader.Windows + Hotsapi.Uploader + v4.6.2 + 512 + {60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} + 4 + true + + + + AnyCPU + true + full + false + bin\Debug\ + TRACE;DEBUG;NOSQUIRREL + prompt + 4 + + + AnyCPU + pdbonly + true + bin\Release\ + TRACE;NOSQUIRREL + prompt + 4 + + + Resources\uploader_icon_light.ico + + + bin\Zip\ + TRACE;NOSQUIRREL + true + pdbonly + AnyCPU + prompt + MinimumRecommendedRules.ruleset + true + + + bin\Installer\ + TRACE + true + pdbonly + AnyCPU + prompt + MinimumRecommendedRules.ruleset + true + + + + + + 1.5.0.235 + + + + + + + + + + + + + + + + + + + + + + + + + 4.0 + + + + + + + + MSBuild:Compile + Designer + + + + SettingsWindow.xaml + + + + + + + + + + MSBuild:Compile + Designer + + + App.xaml + Code + + + MainWindow.xaml + Code + + + Designer + MSBuild:Compile + + + Designer + MSBuild:Compile + + + Designer + MSBuild:Compile + + + MSBuild:Compile + Designer + + + MSBuild:Compile + Designer + + + MSBuild:Compile + Designer + + + MSBuild:Compile + Designer + + + + + Code + + + True + True + Resources.resx + + + True + Settings.settings + True + + + + + + + ResXFileCodeGenerator + Resources.Designer.cs + + + Always + Designer + + + Designer + + + Designer + + + PublicSettingsSingleFileGenerator + Settings.Designer.cs + + + + + Designer + + + + + {DC695BCC-4403-4B20-B4F5-EB80683E5967} + Hotsapi.Uploader.Common + + + + + + + False + + + False + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file