Skip to content

Commit cdc3199

Browse files
committed
refactor: update version extraction method in release workflow
1 parent 7b8cee2 commit cdc3199

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

.github/workflows/release-workflow.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ jobs:
2828
env:
2929
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3030

31-
# Extract version from package.json
32-
- name: Get version from package.json
33-
id: get_version
34-
run: |
35-
echo "VERSION=$(jq -r .version package.json)" >> $GITHUB_ENV
36-
3731
# Run the build commands
3832
- name: Build .zip files
3933
run: |
@@ -62,20 +56,25 @@ jobs:
6256
body: |
6357
This is the release for version ${{ env.VERSION }}.
6458
59+
# Extract version from package.json
60+
- name: get-npm-version
61+
id: package-version
62+
uses: martinbeentjes/npm-get-version-action@v1.3.1
63+
6564
# Upload Chrome release asset
6665
- name: Upload Chrome release asset
6766
uses: actions/upload-release-asset@v1
6867
with:
6968
upload_url: ${{ steps.create_release.outputs.upload_url }}
70-
asset_path: ./out/wechat-reader-enhancer-${{ env.VERSION }}-chrome.zip
71-
asset_name: wechat-reader-enhancer-${{ env.VERSION }}-chrome.zip
69+
asset_path: ./out/wechat-reader-enhancer-${{ steps.package-version.outputs.current-version }}-chrome.zip
70+
asset_name: wechat-reader-enhancer-${{ steps.package-version.outputs.current-version }}-chrome.zip
7271
asset_content_type: application/zip
7372

7473
# Upload Firefox release asset
7574
- name: Upload Firefox release asset
7675
uses: actions/upload-release-asset@v1
7776
with:
7877
upload_url: ${{ steps.create_release.outputs.upload_url }}
79-
asset_path: ./out/wechat-reader-enhancer-${{ env.VERSION }}-firefox.zip
80-
asset_name: wechat-reader-enhancer-${{ env.VERSION }}-firefox.zip
78+
asset_path: ./out/wechat-reader-enhancer-${{ steps.package-version.outputs.current-version }}-firefox.zip
79+
asset_name: wechat-reader-enhancer-${{ steps.package-version.outputs.current-version }}-firefox.zip
8180
asset_content_type: application/zip

0 commit comments

Comments
 (0)