Merge pull request #3 from kamalsaleh/master

The commutative ring of the category of smooth maps is now a dummy field

Author: kamalsaleh

PackageInfo.g

@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "MachineLearningForCAP",
 Subtitle := "Exploring categorical machine learning in CAP",
-Version := "2024.07-09",
+Version := "2024.07-10",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

gap/CategoryOfSkeletalSmoothMaps.gi

@@ -12,7 +12,7 @@ InstallValue( MachineLearningForCAP,
 InstallGlobalFunction( CategoryOfSkeletalSmoothMaps,
 
   function ( )
-    local name, Smooth;
+    local name, Smooth, reals;
 
     name := "SkeletalSmoothMaps";
 
@@ -31,8 +31,19 @@ InstallGlobalFunction( CategoryOfSkeletalSmoothMaps,
     SetIsSymmetricMonoidalCategory( Smooth, true );
     SetIsLinearCategoryOverCommutativeRing( Smooth, true );
 
-    ## Usually we need the field of reals or floats
-    SetCommutativeRingOfLinearCategory( Smooth, Rationals );
+    ##
+    
+    reals := DummyField( );
+    
+    reals!.Name := "Reals";
+    
+    # or IsFloat
+    reals!.RingElementFilter := IsRingElement;
+    
+    # or Float
+    reals!.interpret_rationals_func := IdFunc;
+    
+    SetCommutativeRingOfLinearCategory( Smooth, reals );
 
     ##
     AddObjectConstructor( Smooth,

tst/categorical_vs_direct_constructions.tst

@@ -7,7 +7,6 @@ gap> Assert( 0, Para.QuadraticLoss_( 3 ) = Para.QuadraticLoss( 3 ) );
 gap> Assert( 0, Para.CrossEntropyLoss_( 3 ) = Para.CrossEntropyLoss( 3 ) );
 gap> Assert( 0, Para.SoftmaxCrossEntropyLoss_( 3 ) = Para.SoftmaxCrossEntropyLoss( 3 ) );
 gap> Assert( 0, Para.QuadraticLoss_( 3 ) = Para.QuadraticLoss( 3 ) );
-gap> Assert( 0, Para.QuadraticLoss_( 3 ) = Para.QuadraticLoss( 3 ) );
 gap> Assert( 0, Para.SigmoidBinaryCrossEntropyLoss_( 1 ) = Para.SigmoidBinaryCrossEntropyLoss( 1 ) );
 gap> Assert( 0, Para.AffineTransformation_( 3, 4 ) = Para.AffineTransformation( 3, 4 ) );
 gap> Eval( Smooth.PolynomialTransformation( 2, 3, 4 ), [ 1 .. 47 ] );