Refactor RotatingRaidBotSV for better performance and readability

- Cache den locations using Lazy<> to avoid repeated JSON parsing
- Add region boundary constants (PaldeaRaidCount, KitakamiStartIndex, etc.)
- Simplify WriteProgressLive by consolidating duplicate read/write blocks
- Make TypeAdvantages dictionary static readonly
- Use Raid.SIZE constant instead of magic number 0x20
- Remove unused variable assignment

Author: hexbyt3

SysBot.Pokemon/SV/BotRaid/RotatingRaidBotSV.cs

@@ -117,6 +117,20 @@ public record PlayerInfo
         private const string MysteryRaidTitle = "Mystery Shiny Raid";
         private const string UserRequestedRaidSuffix = "'s Requested Raid";
 
+        // Region boundary constants for raid index calculations
+        private const int PaldeaRaidCount = 69;
+        private const int KitakamiRaidCount = 25;
+        private const int KitakamiStartIndex = PaldeaRaidCount;
+        private const int BlueberryStartIndex = PaldeaRaidCount + KitakamiRaidCount;
+
+        // Cached den locations to avoid repeated JSON loading
+        private static readonly Lazy<Dictionary<string, float[]>> CachedPaldeaDenLocations = new(() =>
+            LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_base.json"));
+        private static readonly Lazy<Dictionary<string, float[]>> CachedKitakamiDenLocations = new(() =>
+            LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_kitakami.json"));
+        private static readonly Lazy<Dictionary<string, float[]>> CachedBlueberryDenLocations = new(() =>
+            LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_blueberry.json"));
+
         /// <summary>
         /// Main execution loop for the raid bot
         /// </summary>
@@ -2381,7 +2395,6 @@ private async Task<int> PrepareForRaid(CancellationToken token)
                 return 2;
             }
 
-            _ = _settings.ActiveRaids[_currentRaidIndex];
             var currentSeed = _settings.ActiveRaids[_currentRaidIndex].Seed.ToUpper();
 
             if (!_denHexSeed.Equals(currentSeed, StringComparison.CurrentCultureIgnoreCase))
@@ -3060,7 +3073,7 @@ private static async Task<bool> IsValidImageUrlAsync(string url)
             }
         }
 
-        private readonly Dictionary<string, string> _typeAdvantages = new()
+        private static readonly Dictionary<string, string> TypeAdvantages = new()
         {
             { "normal", "Fighting" },
             { "fire", "Water, Ground, Rock" },
@@ -3089,7 +3102,7 @@ private string GetTypeAdvantage(string teraType)
         {
             string englishTypeName = GetEnglishTypeNameFromLocalized(teraType);
 
-            if (_typeAdvantages.TryGetValue(englishTypeName.ToLower(), out string advantage))
+            if (TypeAdvantages.TryGetValue(englishTypeName.ToLower(), out string? advantage))
             {
                 return advantage;
             }
@@ -3101,7 +3114,7 @@ private string GetTypeAdvantage(string teraType)
         /// </summary>
         private string GetEnglishTypeNameFromLocalized(string teraType)
         {
-            if (_typeAdvantages.ContainsKey(teraType.ToLower()))
+            if (TypeAdvantages.ContainsKey(teraType.ToLower()))
                 return teraType.ToLower();
             var englishStrings = GameInfo.GetStrings(2);
             var localizedStrings = GameInfo.GetStrings((int)_settings.EmbedToggles.EmbedLanguage);
@@ -4253,6 +4266,20 @@ private static Dictionary<string, float[]> LoadDenLocations(string resourceName)
             return denLocations;
         }
 
+        /// <summary>
+        /// Gets cached den locations for the specified map type
+        /// </summary>
+        private static Dictionary<string, float[]> GetCachedDenLocations(TeraRaidMapParent mapType)
+        {
+            return mapType switch
+            {
+                TeraRaidMapParent.Paldea => CachedPaldeaDenLocations.Value,
+                TeraRaidMapParent.Kitakami => CachedKitakamiDenLocations.Value,
+                TeraRaidMapParent.Blueberry => CachedBlueberryDenLocations.Value,
+                _ => throw new ArgumentException("Invalid map type", nameof(mapType))
+            };
+        }
+
         /// <summary>
         /// Finds the nearest den location to the player
         /// </summary>
@@ -4377,10 +4404,10 @@ private async Task LogPlayerLocation(CancellationToken token)
         {
             var playerLocation = await GetPlayersLocation(token);
 
-            // Load den locations for all regions
-            var blueberryLocations = LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_blueberry.json");
-            var kitakamiLocations = LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_kitakami.json");
-            var baseLocations = LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_base.json");
+            // Use cached den locations for all regions
+            var blueberryLocations = GetCachedDenLocations(TeraRaidMapParent.Blueberry);
+            var kitakamiLocations = GetCachedDenLocations(TeraRaidMapParent.Kitakami);
+            var baseLocations = GetCachedDenLocations(TeraRaidMapParent.Paldea);
 
             // Find the nearest location for each set and keep track of the overall nearest
             var nearestDen = new Dictionary<string, string>
@@ -4394,15 +4421,15 @@ private async Task LogPlayerLocation(CancellationToken token)
             .Where(kv => !string.IsNullOrEmpty(kv.Value))
             .Select(kv =>
             {
-                Dictionary<string, float[]>? denLocations = kv.Key switch
+                var denLocations = GetCachedDenLocations(kv.Key switch
                 {
-                    "Blueberry" => blueberryLocations,
-                    "Kitakami" => kitakamiLocations,
-                    "Paldea" => baseLocations,
-                    _ => null
-                };
+                    "Blueberry" => TeraRaidMapParent.Blueberry,
+                    "Kitakami" => TeraRaidMapParent.Kitakami,
+                    "Paldea" => TeraRaidMapParent.Paldea,
+                    _ => TeraRaidMapParent.Paldea
+                });
 
-                if (denLocations == null || !denLocations.TryGetValue(kv.Value, out var denLocationArray))
+                if (!denLocations.TryGetValue(kv.Value, out var denLocationArray))
                     return null;
 
                 var denLocationTuple = (denLocationArray[0], denLocationArray[1], denLocationArray[2]);
@@ -4479,22 +4506,17 @@ private async Task LogPlayerLocation(CancellationToken token)
             // Read the raw raid data for the region
             byte[] raidData = await ReadRaidsForRegion(mapType, token);
 
-            Dictionary<string, float[]> denLocations = mapType switch
-            {
-                TeraRaidMapParent.Paldea => LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_base.json"),
-                TeraRaidMapParent.Kitakami => LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_kitakami.json"),
-                TeraRaidMapParent.Blueberry => LoadDenLocations("SysBot.Pokemon.SV.BotRaid.DenLocations.den_locations_blueberry.json"),
-                _ => throw new InvalidOperationException("Invalid region")
-            };
+            // Use cached den locations
+            var denLocations = GetCachedDenLocations(mapType);
 
             var activeRaids = new List<(string DenIdentifier, float[] Coordinates, int Index, uint Seed, uint Flags, bool IsEvent)>();
 
             // Calculate the starting index offset based on the map type
             int startingIndex = mapType switch
             {
                 TeraRaidMapParent.Paldea => 0,
-                TeraRaidMapParent.Kitakami => 69,
-                TeraRaidMapParent.Blueberry => 94,
+                TeraRaidMapParent.Kitakami => KitakamiStartIndex,
+                TeraRaidMapParent.Blueberry => BlueberryStartIndex,
                 _ => 0
             };
 
@@ -4533,48 +4555,19 @@ private async Task WriteProgressLive(GameProgress progress)
             if (Connection is null)
                 return;
 
-            if (progress >= GameProgress.Unlocked3Stars)
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty3, CancellationToken.None);
-                await WriteBlock(true, RaidDataBlocks.KUnlockedRaidDifficulty3, CancellationToken.None, toexpect);
-            }
-            else
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty3, CancellationToken.None);
-                await WriteBlock(false, RaidDataBlocks.KUnlockedRaidDifficulty3, CancellationToken.None, toexpect);
-            }
-
-            if (progress >= GameProgress.Unlocked4Stars)
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty4, CancellationToken.None);
-                await WriteBlock(true, RaidDataBlocks.KUnlockedRaidDifficulty4, CancellationToken.None, toexpect);
-            }
-            else
+            var difficultyBlocks = new[]
             {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty4, CancellationToken.None);
-                await WriteBlock(false, RaidDataBlocks.KUnlockedRaidDifficulty4, CancellationToken.None, toexpect);
-            }
-
-            if (progress >= GameProgress.Unlocked5Stars)
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty5, CancellationToken.None);
-                await WriteBlock(true, RaidDataBlocks.KUnlockedRaidDifficulty5, CancellationToken.None, toexpect);
-            }
-            else
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty5, CancellationToken.None);
-                await WriteBlock(false, RaidDataBlocks.KUnlockedRaidDifficulty5, CancellationToken.None, toexpect);
-            }
+                (GameProgress.Unlocked3Stars, RaidDataBlocks.KUnlockedRaidDifficulty3),
+                (GameProgress.Unlocked4Stars, RaidDataBlocks.KUnlockedRaidDifficulty4),
+                (GameProgress.Unlocked5Stars, RaidDataBlocks.KUnlockedRaidDifficulty5),
+                (GameProgress.Unlocked6Stars, RaidDataBlocks.KUnlockedRaidDifficulty6),
+            };
 
-            if (progress >= GameProgress.Unlocked6Stars)
+            foreach (var (requiredProgress, block) in difficultyBlocks)
             {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty6, CancellationToken.None);
-                await WriteBlock(true, RaidDataBlocks.KUnlockedRaidDifficulty6, CancellationToken.None, toexpect);
-            }
-            else
-            {
-                var toexpect = (bool?)await ReadBlock(RaidDataBlocks.KUnlockedRaidDifficulty6, CancellationToken.None);
-                await WriteBlock(false, RaidDataBlocks.KUnlockedRaidDifficulty6, CancellationToken.None, toexpect);
+                bool shouldUnlock = progress >= requiredProgress;
+                var toexpect = (bool?)await ReadBlock(block, CancellationToken.None);
+                await WriteBlock(shouldUnlock, block, CancellationToken.None, toexpect);
             }
         }
 
@@ -4919,15 +4912,11 @@ private static (PK9, uint) IsSeedReturned(ITeraRaid encounter, Raid raid)
         /// </summary>
         private async Task FindSeedIndexInRaids(uint denHexSeedUInt, CancellationToken token)
         {
-            const int kitakamiDensCount = 25;
-            int upperBound = kitakamiDensCount == 25 ? 94 : 95;
-            int startIndex = kitakamiDensCount == 25 ? 94 : 95;
-
             // Search in Paldea region
             var dataP = await SwitchConnection.ReadBytesAbsoluteAsync(_raidBlockPointerP, 2304, token).ConfigureAwait(false);
-            for (int i = 0; i < 69; i++)
+            for (int i = 0; i < PaldeaRaidCount; i++)
             {
-                var seed = BitConverter.ToUInt32(dataP.AsSpan(0x20 + i * 0x20, 4));
+                var seed = BitConverter.ToUInt32(dataP.AsSpan(Raid.SIZE + i * Raid.SIZE, 4));
                 if (seed == denHexSeedUInt)
                 {
                     _seedIndexToReplace = i;
@@ -4937,21 +4926,21 @@ private async Task FindSeedIndexInRaids(uint denHexSeedUInt, CancellationToken t
 
             // Search in Kitakami region
             var dataK = await SwitchConnection.ReadBytesAbsoluteAsync(_raidBlockPointerK + 0x10, 0xC80, token).ConfigureAwait(false);
-            for (int i = 0; i < upperBound; i++)
+            for (int i = 0; i < BlueberryStartIndex; i++)
             {
-                var seed = BitConverter.ToUInt32(dataK.AsSpan(i * 0x20, 4));
+                var seed = BitConverter.ToUInt32(dataK.AsSpan(i * Raid.SIZE, 4));
                 if (seed == denHexSeedUInt)
                 {
-                    _seedIndexToReplace = i + 69;
+                    _seedIndexToReplace = i + KitakamiStartIndex;
                     return;
                 }
             }
 
             // Search in Blueberry region
             var dataB = await SwitchConnection.ReadBytesAbsoluteAsync(_raidBlockPointerB + 0x10, 0xA00, token).ConfigureAwait(false);
-            for (int i = startIndex; i < 118; i++)
+            for (int i = BlueberryStartIndex; i < 118; i++)
             {
-                var seed = BitConverter.ToUInt32(dataB.AsSpan((i - startIndex) * 0x20, 4));
+                var seed = BitConverter.ToUInt32(dataB.AsSpan((i - BlueberryStartIndex) * Raid.SIZE, 4));
                 if (seed == denHexSeedUInt)
                 {
                     _seedIndexToReplace = i - 1;