From bbc8a114e8b2d580ab769a58729294c0c17dced0 Mon Sep 17 00:00:00 2001 From: Harald Fernengel Date: Tue, 21 Jan 2025 16:40:16 +0100 Subject: [PATCH] Do not propagate -Werror from leveldb Setting -Werror as PUBLIC flag means that all targets that link to leveldb will stop compiling on the first warning. An intermediate library must never propagate that flag to parent projects. Relates-To: MINOR Signed-off-by: Harald Fernengel --- external/leveldb/CMakeLists-leveldb.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/external/leveldb/CMakeLists-leveldb.txt b/external/leveldb/CMakeLists-leveldb.txt index e1a9e33cc..0c51fc405 100644 --- a/external/leveldb/CMakeLists-leveldb.txt +++ b/external/leveldb/CMakeLists-leveldb.txt @@ -247,7 +247,10 @@ endif(BUILD_SHARED_LIBS) if(HAVE_CLANG_THREAD_SAFETY) target_compile_options(leveldb PUBLIC - -Werror -Wthread-safety) + -Wthread-safety + PRIVATE + -Werror + ) endif(HAVE_CLANG_THREAD_SAFETY) if(HAVE_CRC32C)