Nix tooling (minor changes) (#4490)

* Nix: Update lock files (GHC 9.6.5 -> 9.6.6)

* Nix Flake: Small fixes, make comments a bit more consistent

* Nix Flake: Remove `hlint`

`hlint` should not be necessary. However, this is an opinion up for debate:

We do not really need the `hlint` executable because it is integrated in HLS.

However, `hlint` is used by a GitHub Action, which we may want to replicate locally.

Also, the `fmt.sh` script is downloading an (unknown) `hlint` version which will
not work on NixOS anyways. In my opinion, if `fmt.sh` is still used (I can not
find any usages) we should fix the script so it is reproducible.

Author: dschrempf

flake.lock

@@ -4,15 +4,15 @@
   inputs = {
     nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
     flake-utils.url = "github:numtide/flake-utils";
-    # for default.nix
+    # For default.nix
     flake-compat = {
       url = "github:edolstra/flake-compat";
       flake = false;
     };
   };
 
   outputs =
-    inputs@{ self, nixpkgs, flake-utils, ... }:
+    { nixpkgs, flake-utils, ... }:
     flake-utils.lib.eachSystem [ "x86_64-linux" "x86_64-darwin" "aarch64-linux" "aarch64-darwin" ]
     (system:
       let
@@ -50,25 +50,21 @@
 
         mkDevShell = hpkgs: with pkgs; mkShell {
           name = "haskell-language-server-dev-ghc${hpkgs.ghc.version}";
-          # For binary Haskell tools, we use the default nixpkgs GHC
-          # This removes a rebuild with a different GHC version
-          # The drawback of this approach is that our shell may pull two GHC
-          # version in scope.
+          # For binary Haskell tools, we use the default Nixpkgs GHC version.
+          # This removes a rebuild with a different GHC version. The drawback of
+          # this approach is that our shell may pull two GHC versions in scope.
           buildInputs = [
-            # our compiling toolchain
+            # Compiler toolchain
             hpkgs.ghc
             pkgs.haskellPackages.cabal-install
-            # Dependencies needed to build some parts of hackage
+            # Dependencies needed to build some parts of Hackage
             gmp zlib ncurses
             # Changelog tooling
             (gen-hls-changelogs pkgs.haskellPackages)
             # For the documentation
             pythonWithPackages
-            # @guibou: I'm not sure this is needed.
-            hlint
             (pkgs.haskell.lib.justStaticExecutables (pkgs.haskell.lib.dontCheck pkgs.haskellPackages.opentelemetry-extra))
             capstone
-            # ormolu
             stylish-haskell
             pre-commit
             ] ++ lib.optionals (!stdenv.isDarwin)
@@ -92,7 +88,7 @@
           '';
         };
 
-      in with pkgs; rec {
+      in rec {
         # Developement shell with only dev tools
         devShells = {
           default = mkDevShell pkgs.haskellPackages;
@@ -102,9 +98,7 @@
           shell-ghc910 = mkDevShell pkgs.haskell.packages.ghc910;
         };
 
-        packages = {
-          docs = docs;
-        };
+        packages = { inherit docs; };
 
         # The attributes for the default shell and package changed in recent versions of Nix,
         # these are here for backwards compatibility with the old versions.