Follow hlint suggestion: use void#11849
Open
philderbeast wants to merge 1 commit into
Open
Conversation
Bodigrim
reviewed
May 18, 2026
Bodigrim
reviewed
May 18, 2026
Bodigrim
approved these changes
May 19, 2026
Mikolaj
approved these changes
May 21, 2026
philderbeast
force-pushed
the
hlint/use-void
branch
3 times, most recently
from
4cde689 to
aec6323
Compare
philderbeast
added
merge me
philderbeast
force-pushed
the
hlint/use-void
branch
from
aec6323 to
8ef17ba
Compare
mergify
Bot
added
the
ready and waiting
philderbeast
force-pushed
the
hlint/use-void
branch
from
8ef17ba to
f5afe06
Compare
Collaborator
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 1 hour 23 minutes 54 seconds in the queue, including 1 hour 13 minutes 35 seconds running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
86 tasks
- Redo counts - Minimize diffs - Inline monitorReason' = void monitorReason - One more application of void - Use $ and not parentheses - Use -XLambdaCase for instantiate unitId work
philderbeast
force-pushed
the
hlint/use-void
branch
from
f5afe06 to
a405aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores HLint's "use void" suggestion so that these will be suggested by our CI linting.
I'll squash commits before applying the merge label if this pull request is approved. The first commit resets the
# countcomments in.hlint.yaml.