Skip to content

Commit 8d113b2

Browse files
committed
fix: suggestions from code review
1 parent 73abf69 commit 8d113b2

File tree

6 files changed

+24
-4
lines changed

6 files changed

+24
-4
lines changed

libs/@local/hashql/mir/src/pass/execution/placement/solve/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
//! that can change its assignment.
1010
//!
1111
//! Entry point: [`PlacementSolverContext::build_in`] constructs a [`PlacementSolver`], then
12-
//! [`PlacementSolver::run`] executes both passes.
12+
//! [`PlacementSolver::run_in`] executes both passes.
1313
1414
use core::{alloc::Allocator, mem};
1515

libs/@local/hashql/mir/src/pass/execution/tests.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,18 @@ fn assert_execution<'heap>(
163163
.expect("infallible");
164164
}
165165

166+
#[expect(clippy::use_debug)]
167+
for edge in islands.iter_edges() {
168+
writeln!(
169+
output,
170+
" bb{} -> bb{}: {:?}",
171+
edge.source(),
172+
edge.target(),
173+
edge.data
174+
)
175+
.expect("infallible");
176+
}
177+
166178
let dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
167179
let mut settings = Settings::clone_current();
168180
settings.set_snapshot_path(dir.join("tests/ui/pass/execution"));

libs/@local/hashql/mir/src/pass/execution/traversal/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ impl TraversalPath {
265265
/// accesses across all vertex types in a query. Where [`TraversalPathBitSet`] tracks paths for a
266266
/// single vertex type, the bitmap tracks paths for all of them.
267267
///
268-
/// Lattice operations are pointwise via [`TraversalBitMapLattice`]: bottom is all-empty, top has
268+
/// Lattice operations are pointwise via [`TraversalMapLattice`]: bottom is all-empty, top has
269269
/// every slot at its [`TraversalPathBitSet`] top, and join unions each slot independently.
270270
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
271271
pub struct TraversalPathBitMap(

libs/@local/hashql/mir/tests/ui/pass/execution/entity_uuid_equality.snap

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/@local/hashql/mir/tests/ui/pass/execution/mixed_postgres_embedding_interpreter.snap

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/@local/hashql/mir/tests/ui/pass/execution/projection_and_apply_splits.snap

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)