BUG/MEDIUM: cluster: solve race condition on connecting on cold start

oktalz · aiharos · commit c9437cd5dd2b · 2021-04-06T16:58:33.000+02:00
low GOMAXPROCS value can cause issue that notification about bootstrap key changed is issued before app is actually subscribed to that event. Therefore, it can miss notification and do nothing
diff --git a/configuration/cluster_sync.go b/configuration/cluster_sync.go
@@ -30,6 +30,7 @@ import (
 	"net/http"
 	"os"
 	"path"
+	"runtime"
 	"strings"
 	"time"
 
@@ -82,6 +83,7 @@ func (c *ClusterSync) Monitor(cfg *Configuration, cli *client_native.HAProxyClie
 	certFetched := cfg.Cluster.Certificate.Fetched.Load()
 
 	if key != "" && !certFetched {
+		runtime.Gosched()
 		c.cfg.Notify.BootstrapKeyChanged.Notify()
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ import (`
`30`	`30`	`"net/http"`
`31`	`31`	`"os"`
`32`	`32`	`"path"`
	`33`	`+ "runtime"`
`33`	`34`	`"strings"`
`34`	`35`	`"time"`
`35`	`36`
`@@ -82,6 +83,7 @@ func (c ClusterSync) Monitor(cfg Configuration, cli *client_native.HAProxyClie`
`82`	`83`	`certFetched := cfg.Cluster.Certificate.Fetched.Load()`
`83`	`84`
`84`	`85`	`if key != "" && !certFetched {`
	`86`	`+ runtime.Gosched()`
`85`	`87`	`c.cfg.Notify.BootstrapKeyChanged.Notify()`
`86`	`88`	`}`
`87`	`89`	`}`