Skip to content

test_html_document_without_doctype fails with haml 6 and nokogiri 1.18 #97

@boutil

Description

@boutil

Hi,

In debian, the test test_html_document_without_doctype started failing. We use haml 6.3.0 and nokogiri 1.18.10.
When converting a html document without meta tag, there is no default value generated in the haml version.
Should we consider this as a bug? I could not find in the haml documentation that it is supposed to be generated in the haml version if not present in the originial html document.

  1) Failure:
Html2HamlTest#test_html_document_without_doctype [test/html2haml_test.rb:405]:
--- expected
+++ actual
@@ -1,7 +1,6 @@
 "!!!
 %html
   %head
-    %meta{:content => \"text/html; charset=UTF-8\", \"http-equiv\" => \"Content-Type\"}/
     %title Hello
   %body
     %p Hello"

See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1120233
I am tempted to either skip the test or "fix it" by removing the %meta line from the expected result, but I wonder if it is safe...
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions