-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
feature requestA request for a new feature unlike one that already existsA request for a new feature unlike one that already exists
Description
Taxonomic classification is reliant on the evolutionary distance (i.e. branch-length, or number of substitutions) linear model. Distances between query sequences and reference sequences inferred during phylogenetic placement are influenced by the underlying reference alignment, and therefore the MSA trimming process. This causes a conflict when, for example, a model trained on a BMGE-trimmed MSA is used to correct classifications derived from ClipKit-trimmed MSA.
Potential Solutions
- Every time
treesapp assignis executed, the parameters are compared to those that were used to create the reference package. If there are differences that could influence the phylogeny, the reference package is automatically re-trained. MSA-trimming software name, mode and parameters would need to be stored. Creating a parser to extract these attributes for each trimming software would be inconvenient, and potentially unstable across multiple versions. - The linear model would be obsolete by using relative evolutionary distance (RED) to dynamically set taxonomic rank boundaries. Even this route, however, would require repeating phylogenetic inference of the reference phylogeny so that the MSA is the same.
- Remove the option of trimming the MSA during phylogenetic placement, only during
treesapp create/update. The raw reference leaf sequences would need to be stored in the refpkg sotreesapp updateandtreesapp traincan access the raw sequences.
Acceptance criteria
- Reference package includes a namedtuple that stores trimming parameters
-
--trim_alignand related arguments are removed from all subcommands exceptcreateandupdate - Linear model used for rank recommendation stores MSA and phylogeny dimensions to ensure compatibility.
- Store raw, dereplicated (at 99% identity) amino acid and nucleotide (if available) sequence records input to
treesapp create, including all candidate sequences unused. These include records that passed the taxonomic screen & filter, and length thresholds.- Sequence and sequence name (i.e. FASTA attributes)
- Genome, chromosome, contig, and/or ORF position of sequence
- Compress reference package to decrease space required for additional sequences
Metadata
Metadata
Assignees
Labels
feature requestA request for a new feature unlike one that already existsA request for a new feature unlike one that already exists