LiveEvent class should not inherit from MediatorLiveData?

[hkusu]

Currently, LiveEvent class inherits from MediatorLiveData. However, when using addSource(), the correct result is not obtained.

For example, if you rewrite the following test code, the test will fail.

LiveEvent/live-event/src/test/java/com/hadilq/liveevent/LiveEventTest.kt

Lines 146 to 163 in 1c72b2d

	@Test
	fun `observe after emit event`() {
	// Given
	owner.create()
	val event = "event"
	liveEvent.value = event
	liveEvent.observe(owner, observer)
	// When
	owner.start()
	// Then
	if (config == LiveEventConfig.Normal) {
	verify(observer, never()).onChanged(event)
	} else {
	verify(observer, times(1)).onChanged(event)
	}
	}

@Test
fun `observe after emit event`() {
    // Given
    val mutableLiveData = MutableLiveData<String>()
    liveEvent.addSource(mutableLiveData) {
        liveEvent.value = it
    }
    owner.create()
    val event = "event"
    mutableLiveData.value = event
    liveEvent.observe(owner, observer)

    // When
    owner.start()

    // Then
    if (config == LiveEventConfig.Normal) {
        verify(observer, never()).onChanged(event) // This test does not pass
    } else {
        verify(observer, times(1)).onChanged(event)
    }
}

Should the LiveEvent class be an inheritance of MutableLiveData?

[hadilq]

Thanks @hkusu for your feedback. Could you share your usage of addSource in the test? The tests have been passed when I pushed based on the status of CI.

Regarding your question, as you can see in its source code, MediatorLiveData extends MutableLiveData.

public class MediatorLiveData<T> extends MutableLiveData<T>

so it has all the features of MutableLiveData.

[hkusu]

LiveEvent does not behave as expected when used as MediatorLiveData. The purpose of this issue is to stop inheriting MediatorLiveData to avoid confusion.

[hadilq]

@hkusu what do you expect that it's not following? Also would you give me a clue why the test didn't pass as you claimed above? Thanks!