Default database fails if username is not postgres.

[Dunedubby]

First off, this crate is great and exactly what we needed for our tests. Definitely happy to help maintain it going forward, or maybe to help merge it with the main sqlx codebase.

So for the issue: if the username is not postgres (I think quite common in some managed DB cloud offerings), then this will use the username as the database on which CREATE DATABASE is called. Many times, this database will not exist.

It seems that more consistent solution would be to just use postgres as the default CREATE DATABASE context, and then maybe have the option of using something else if an environment variable, e.g. DEFAULT_DATABASE_NAME, is supplied.

I've created a fork with this change. What do you think?

[gzigzigzeo]

Hey, @Dunedubby!

Thank you. I think, merging it with sqlx would be definitely a way to go. I'd be happy to help. Sorry for the late answer, I was away for the last two weeks.

Yes, I agree, this makes sense. The problem is that we can't specify template database name and service connection database name in the same DATABASE_URL, right? I am not sure, but in this case I'd probably named this variable more explicit, somehow like SERVICE_CONNECTION_DATABASE_NAME.