Illegal JSON on `retrieveMissingBillPayment()` from BillPayment integration tests

[cesdias]

Illegal JSON on retrieveMissingBillPayment() from BillPayment integration tests

The test case retrieveMissingBillPayment() from BillPayment integration test is returning a JsonSyntaxException on line 226 of the file BillPaymentTest.java. Although this indicates a malformed JSON on the responses of the Simulator, I could not see any malformed JSON when I make requests directly to the MMAPI Endpoints on the simulator.

Steps to reproduce

For debug purposes:

1. Insert on the line 224 of the file BillPaymentTest.java the following line of code:

System.out.println(clientCorrelationId);

Run the test:

1. Run the integration test retrieveMissingBillPayment()
2. You will see the clientCorrelationId printed on the console. e.g. 80f5404b-0713-42f3-ae66-216ad3d69c0d
3. The exception com.google.gson.JsonSyntaxException is thrown on the line 226

Testing against MMAPI Simulator:

4. Get the clientCorrelationId and make the request directly to the MMAPI:

curl --location --request GET 'https://sandbox.mobilemoneyapi.io/simulator/v1.2/passthrough/mm/responses/80f5404b-0713-42f3-ae66-216ad3d69c0d'

5. Get the link from the JSON response and make another request to the MMAPI:

curl --location --request GET 'https://sandbox.mobilemoneyapi.io/simulator/v1.2/passthrough/mm/accounts/msisdn@+449999999/bills

Both JSON returned from steps 4 and 5 are corrected.

Expected outcome

The test case must be able to parse JSON from the steps 4 and 5.

Actual outcome

The exception com.google.gson.JsonSyntaxException is thrown indicating that a JSON is malformed.

[jithin-fingent]

We are looking into this and will keep you posted.

[jithin-fingent]

BillPayMissingApi Issue.docx
@cesdias here are my findings - could you please check and confirm the same whether it is correct?

[cesdias]

@jithin-fingent thanks for the investigation.

I could find the same information you provided, but just to clarify: are you expecting that the link in the response represents only single billpay not linked to an account?

What I have seen in my tests is that all the clientCorrelationIds created for this test are returning a link associated with an account (e.g. {"link":"/accounts/msisdn@+44012345678/bills"}

You can also try to change the account id from "walletid" and "1" to "msisdn" and "+44012345678". This account id will return a link with only one billpay associated to this account.

Apart from that, we are still getting the Exception, which seems related to some malformed JSON.

Exception:

com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at line 1 column 2 path $
 at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read([ReflectiveTypeAdapterFactory.java:226]())
 at com.google.gson.Gson.fromJson([Gson.java:932]())
 at com.google.gson.Gson.fromJson([Gson.java:897]())
 at com.google.gson.Gson.fromJson([Gson.java:846]())
 at com.google.gson.Gson.fromJson([Gson.java:817]())
 at com.mobilemoney.base.util.JSONFormatter.fromJSON([JSONFormatter.java:65]())
 at com.mobilemoney.common.request.CommonRequest.viewResponse([CommonRequest.java:58]())
 at com.mobilemoney.integration.billpayment.BillPaymentTest.viewResponseTestSuccess([BillPaymentTest.java:225]())
 ...

[sanalsfingent]

@cesdias these are our findings

As per the documentation, we are expecting a response of a single billpay object for that particular clientCorrelationId, but we are getting an array of billpay objects done on that particular account.

We tried changing the account id to "msisdn" and "+44012345678", the response is still inside an array even though the response only contain one billpay
and that is why we keep getting the exception Expected BEGIN_OBJECT but was BEGIN_ARRAY.

Given below is a sample CALLBACK response for creating bill payment. We expect the billpay response api to return the same response, since they must be the same.

{
    billPaymentStatus: "unpaid"
    amountPaid: "50.00"
    currency: "GBP"
    creationDate: "2022-02-10T06:36:48.909"
    modificationDate: "2022-02-10T06:36:48.909"
}

[cesdias]

@sanalsfingent I will open a issue on the simulator side. Thanks.

[jithin-fingent]

Noted. Please let us know if anything needs to be done from our side.