code review_shanshan #10
Description
• At first, I want to comment on every branch in your github since I thought different branches should contain different parts of your project. But it seems that all your branches have something in common.
• There are 8 branches in your github, 4 of your branches have the same README.md file which is the summary of your project, the rest 4 branches have the same README.md file which shows pictures about your object detection.
o If those branches are same, it is not necessary to set up so many branches.
o If those branches do have differences, please make some explanation in your README.md file.
o As for the description in README.md file, I think the summary one is clear, and I like the ‘Navigation Folder’ part, which makes it easier to follow what you’ve done.
• I found the folder ’paper’ is about the background you’ve researched, I thought it should not be put in inputFrames-opencv , newjiali , python_test_opencv and work branches since those branches are aimed to show your cpp_test or python_test.
• There is no instructions for running/installing the Android application. Although it is easy for students in EC601 to run it in Android Studio, it is better to have a brief instruction for running the app.
• Your code written in cpp and python is easy to follow, the variable names are descriptive and the functions are grouped together in an understandable manner, but some lines might not follow all PEP-8 conventions.