From 706489d2c4fe9c25c3d3a7eae4367593e6d9ebeb Mon Sep 17 00:00:00 2001 From: Thang PHAM Date: Thu, 21 May 2026 19:32:52 +0200 Subject: [PATCH 1/2] Show error message in DnDTable Signed-off-by: Thang PHAM --- src/components/dialogs/limits/limits-side-pane.tsx | 3 +++ src/components/dialogs/limits/temporary-limits-table.tsx | 5 +++-- .../global-model-editor/columnName-editor.tsx | 1 - 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/components/dialogs/limits/limits-side-pane.tsx b/src/components/dialogs/limits/limits-side-pane.tsx index 2815da24ac..a462666847 100644 --- a/src/components/dialogs/limits/limits-side-pane.tsx +++ b/src/components/dialogs/limits/limits-side-pane.tsx @@ -74,6 +74,7 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.TEXT as const, maxWidth: 200, + //hideErrorMessage: true, }, { label: 'TemporaryLimitDuration', @@ -82,6 +83,7 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.NUMERIC as const, maxWidth: 100, + //hideErrorMessage: true, }, { label: 'TemporaryLimitValue', @@ -90,6 +92,7 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.NUMERIC as const, maxWidth: 100, + //hideErrorMessage: true, }, ].map((column) => ({ ...column, diff --git a/src/components/dialogs/limits/temporary-limits-table.tsx b/src/components/dialogs/limits/temporary-limits-table.tsx index b726e840f8..0cdc476512 100644 --- a/src/components/dialogs/limits/temporary-limits-table.tsx +++ b/src/components/dialogs/limits/temporary-limits-table.tsx @@ -44,16 +44,17 @@ interface CustomTableCellProps { function EditableTableCell({ name, column, previousValue, valueModified, ...props }: Readonly) { return ( - + {column.type === DndColumnType.NUMERIC ? ( ) : ( - + )} ); diff --git a/src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx b/src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx index 7342c2e66c..0635e74d97 100644 --- a/src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx +++ b/src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx @@ -29,7 +29,6 @@ export default function ColumnNameEditor({ name, rowIndex, generateColumnId }: C autoFocus: true, onBlur: onBlurColumnName, }} - showErrorMsg={true} /> ); } From 9bf20e525f98208daae2306fcde7bd7e4f639f5a Mon Sep 17 00:00:00 2001 From: Thang PHAM Date: Thu, 21 May 2026 19:35:30 +0200 Subject: [PATCH 2/2] clean code Signed-off-by: Thang PHAM --- src/components/dialogs/limits/limits-side-pane.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/components/dialogs/limits/limits-side-pane.tsx b/src/components/dialogs/limits/limits-side-pane.tsx index a462666847..2815da24ac 100644 --- a/src/components/dialogs/limits/limits-side-pane.tsx +++ b/src/components/dialogs/limits/limits-side-pane.tsx @@ -74,7 +74,6 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.TEXT as const, maxWidth: 200, - //hideErrorMessage: true, }, { label: 'TemporaryLimitDuration', @@ -83,7 +82,6 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.NUMERIC as const, maxWidth: 100, - //hideErrorMessage: true, }, { label: 'TemporaryLimitValue', @@ -92,7 +90,6 @@ export function LimitsSidePane({ editable: true, type: DndColumnType.NUMERIC as const, maxWidth: 100, - //hideErrorMessage: true, }, ].map((column) => ({ ...column,