Syllable spacing in Lua#420
Open
davidweichiang wants to merge 29 commits into
Open
Conversation
They hyphen must be placed last within the wildcard place holder to represent an actual hyphen. Otherwise it's interpreted as a range between the two characters on either side of it.
This output had a couple of unescaped periods in it.
4 tasks
…ween syllable rewriting and point-and-click. The output in this commit is from commit gregorio-project/gregorio@c5b44a7, demonstrating that syllable rewriting is broken.
…that syllable rewriting is fixed with point-and-click (This also accepts the shift in the notes that was caused by commit gregorio-project/gregorio@02ec952.)
…ffect the purpose of the test)
…ofscore Unset \gre@ifbeginningofscore in \GreBarSyllables
…ween syllable rewriting and point-and-click. The output in this commit is from commit gregorio-project/gregorio@c5b44a7, demonstrating that syllable rewriting is broken.
…that syllable rewriting is fixed with point-and-click (This also accepts the shift in the notes that was caused by commit gregorio-project/gregorio@02ec952.)
…spacestretchyphen when text is hidden
…ang/gregorio-test into lua-syllable-spacing
Contributor
Author
|
I accepted the changed tests in separate commits depending on their severity. There are five tests that I still haven't accepted, because I think they might not be improvements and they should be examined more carefully first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with gregorio-project/gregorio#1720.