Improved error repr

Author: syrusakbary

graphql/error/base.py

@@ -3,15 +3,16 @@
 
 
 class GraphQLError(Exception):
-    __slots__ = 'message', 'nodes', 'stack', 'original_error', '_source', '_positions'
+    __slots__ = 'message', 'nodes', 'stack', 'original_error', '_source', '_positions', '_locations'
 
-    def __init__(self, message, nodes=None, stack=None, source=None, positions=None):
+    def __init__(self, message, nodes=None, stack=None, source=None, positions=None, locations=None):
         super(GraphQLError, self).__init__(message)
         self.message = message
         self.nodes = nodes
         self.stack = stack
         self._source = source
         self._positions = positions
+        self._locations = locations
 
     @property
     def source(self):
@@ -38,6 +39,8 @@ def reraise(self):
 
     @property
     def locations(self):
-        source = self.source
-        if self.positions and source:
-            return [get_location(source, pos) for pos in self.positions]
+        if not self._locations:
+            source = self.source
+            if self.positions and source:
+                self._locations = [get_location(source, pos) for pos in self.positions]
+        return self._locations

graphql/language/location.py

@@ -9,7 +9,7 @@ def __init__(self, line, column):
         self.column = column
 
     def __repr__(self):
-        return '<SourceLocation line={} column={}>'.format(self.line, self.column)
+        return 'SourceLocation(line={}, column={})'.format(self.line, self.column)
 
     def __eq__(self, other):
         return (

graphql/language/tests/test_location.py

@@ -3,4 +3,4 @@
 
 def test_repr_source_location():
     loc = SourceLocation(10, 25)
-    assert repr(loc) == '<SourceLocation line=10 column=25>'
+    assert repr(loc) == 'SourceLocation(line=10, column=25)'